8000 Chords like A7+5 is parsed incorrectly · Issue #609 · no-chris/chord-symbol · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Chords like A7+5 is parsed incorrectly #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
perivar opened this issue Feb 7, 2023 · 2 comments · Fixed by #610
Closed

Chords like A7+5 is parsed incorrectly #609

perivar opened this issue Feb 7, 2023 · 2 comments · Fixed by #610
Labels
bug Something isn't working

Comments

@perivar
Copy link
perivar commented Feb 7, 2023

A7+5 is incorrectly parsed into A5, the same is A7(+5) instead of A7(#5).
However A7+ is correctly parsed into A7(#5).
The same error applies to A7-5, which is parsed into A5, instead of A7(b5).

My fix which seem to work for now is:
let valueCleaned = value;
valueCleaned = valueCleaned.replace(/+5/g, '(#5)');
valueCleaned = valueCleaned.replace(/-5/g, '(b5)');
@no-chris no-chris added the bug Something isn't working label Feb 7, 2023
@no-chris
Copy link
Owner
no-chris commented Feb 7, 2023

Thanks for the report!
This will be fixed in 4.0.0

@no-chris no-chris linked a pull request Feb 7, 2023 that will close this issue
Allow parsing of +5 as #5 and -5 as b5 #610
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in The ChordMark Project Feb 7, 2023
@no-chris
Copy link
Owner
no-chris commented 7478 Feb 7, 2023

Available in v4.0.0-beta.4

@no-chris no-chris moved this from Done to Archive in The ChordMark Project Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
The ChordMark Project
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow parsing of +5 as #5 and -5 as b5 no-chris/chord-symbol
2 participants
@perivar @no-chris
0