8000 Set up test profile · Issue #20 · nf-core/mcmicro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set up test profile #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmuhlich opened this issue Mar 18, 2024 · 5 comments
Closed

Set up test profile #20

jmuhlich opened this issue Mar 18, 2024 · 5 comments
Assignees
@RobJY
Labels
enhancement Improvement for existing functionality

Comments

@jmuhlich
Copy link
Member

Description of feature

The test profile should run our small tonsil test image data through as much of the pipeline as we have working.
@jmuhlich jmuhlich added the enhancement Improvement for existing functionality label Mar 18, 2024
@RobJY RobJY self-assigned this Mar 19, 2024
@RobJY
Copy link
Contributor
RobJY commented Mar 19, 2024

From the rnaseq repo it looks like we should have the input parameters in the test-dataset repo so we can use URLs in test.config and related files. Is this correct or should I just try to use the files from our assets directory?

Should we do multiple test profiles like:

  • test: minimal run using 1 row per sample per cycle samplesheet with no illumination correction so we just need input_cycle and marker_sheet parameters.
  • test_cycle_basicpy: same as test, but include basicpy illumination correction
  • test_sample_basicpy: minimal run using 1 row per sample samplesheet with basicpy illumination correction

@RobJY
Copy link
Contributor
RobJY commented Mar 19, 2024

We may want to improve the quality of the sample and marker sheets before we put them in the test data repo since I just put in garbage values to have something to run.

@RobJY
Copy link
Contributor
RobJY commented Mar 19, 2024 •
edited
Loading

I'm already using URLs for the 1 row per sample per cycle samplesheets, but I still have full paths in the ones for 1 row per sample because they require an image_directory. I guess we could specify an S3 bucket 'directory'? Is there a better way to do this?

@jmuhlich
Copy link
Member Author

I hacked something together in the recent PR that was just merged to dev. It uses a local sample sheet that's committed to the mcmicro repo, but I reference it via its raw.githubusercontent.com URL. I think the correct long-term solution is to commit the test samplesheets and marker sheets to the (as yet nonexistent) mcmicro branch in the test-datasets repo and reference them by https URL from there.

@jmuhlich
Copy link
Member Author

Since #26 also introduces a minimally functional test profile and our CI now requires it to run successfully, I'll close this. We can improve the test profile setup with a more expansive sample sheet as time goes on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobJY RobJY

Labels
enhancement Improvement for existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmuhlich @RobJY
0