Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 1 commit
- 1 file changed
- 1 contributor
Commits on May 22, 2025
-
Fixed primary bonus for Jala spells
Fix primary bonus for Jala spells Jala's primary bonus is unintentionally capped at 30 when it's supposed to exceed that cap based on your instrument. Normally the primary bonus to most spell schools is capped at a max of 30. However, comments left about Jala spells state that its primary bonus is based on the wielded instrument, and that the bonus can go up to 40 because instruments with higher bonuses were harder to find. Unfortunately, the primary bonus for Jala would first be calculated by getting the instrument level, then afterwards the bounds for primary bonuses sets it back to the max of 30. This meant true lutes gave the same strength as fine lutes. This PR does the following: - The bounds for the primary and secondary bonuses were moved above the if-statement for Jala, which allows it to override the values with its own caculations for Jala spells. - A bound is applied again on iSecondaryBonus for Jala, so it can maintain its intended max cap of 10. I tested this on a 150HP player character with normal lute, fine lute, and true lute. The true lute can now give the instrument power of 40, and the secondary bonus is capped at 10 as intended.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master