8000 Increase character set for scan ids · Issue #66 · natlas/natlas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Increase character set for scan ids #66
Closed
< 6926 a class="Avatar-module__avatarLink--S36bm Avatar-module__avatarOuter--MZJZH prc-Link-Link-85e08" href="https://github.com/0xdade" data-hovercard-url="/users/0xdade/hovercard" aria-label="@0xdade's profile">@0xdade

Description

@0xdade

We are using ascii_lowercase and string.digits for the scan_id field right now, which does provide us a lot of options but since it's random we have potential to generate collisions. The reason it's only using string. ascii_lowercase + string.digits is because elasticsearch is filtering that token as lowercase. In order to allow scan_id to be case sensitive, we would need to implement a custom elasticsearch filter for scan_id such that it doesn't lowercase all the characters. Then we can add string.ascii_uppercase to our ID character set.

If this can be done entirely programmatically then I'll do it. Otherwise nah.

Metadata

Metadata

Assignees

No one assigned

    Labels

    agentaffecting natlas-agentenhancementNew feature or requestserveraffecting natlas-server

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0