8000 Increase character set for scan ids · Issue #66 · natlas/natlas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Increase character set for scan ids #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0xdade opened this issue Feb 1, 2019 · 1 comment
8000
Closed

Increase character set for scan ids #66

0xdade opened this issue Feb 1, 2019 · 1 comment
Labels
agent affecting natlas-agent enhancement New feature or request server affecting natlas-server

Comments

@0xdade
Copy link
Member
0xdade commented Feb 1, 2019

We are using ascii_lowercase and string.digits for the scan_id field right now, which does provide us a lot of options but since it's random we have potential to generate collisions. The reason it's only using string. ascii_lowercase + string.digits is because elasticsearch is filtering that token as lowercase. In order to allow scan_id to be case sensitive, we would need to implement a custom elasticsearch filter for scan_id such that it doesn't lowercase all the characters. Then we can add string.ascii_uppercase to our ID character set.

If this can be done entirely programmatically then I'll do it. Otherwise nah.
@0xdade 0xdade added enhancement New feature or request server affecting natlas-server agent affecting natlas-agent labels Feb 1, 2019
@0xdade
Copy link
Member Author
0xdade commented Feb 5, 2019

I might be able to make the id field for nmap_history a composite key like "id": ip:scan_id which would help fix namespaces and make all scan ids deterministically linked to that ip address. I'm not sure how to do such a key using appropriate types, the id might just have to be a string type.

@0xdade 0xdade added this to the v0.6 milestone Feb 16, 2019
@0xdade 0xdade modified the milestones: v0.6, v0.7 Mar 9, 2019
@0xdade 0xdade closed this as completed in 608e204 Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent affecting natlas-agent enhancement New feature or request server affecting natlas-server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xdade
0