8000 Install fech-source over https · Issue #84 · nytimes/Fech · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 6, 2019. It is now read-only.

Install fech-source over https #84

Open
zstumgoren opened this issue Jul 28, 2017 · 0 comments
Open

Install fech-source over https #84

zstumgoren opened this issue Jul 28, 2017 · 0 comments

Comments

@zstumgoren
Copy link
Contributor

Fech currently installs the fech-source submodule (specified in .gitmodules) using the git/ssh strategy. This causes a source-based install of Fech -- via bundler in our case -- to fail for a user that doesn't have an ssh public key on Github.

Here's an example gist demonstrating the issue.

This likely won't be a problem for local development by most contributors, who presumably have a Github account with their ssh key.

But it proved problematic for us in a production context, where we're installing Fech from source while we await release of a new Gem version that contains the FEC v8.2 fix.

Updating .gitmodules to use https for fech-source resolves the issue.

PR to follow.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zstumgoren
0