10000 Upload binaries to Github Releases? · Issue #43 · nu774/fdkaac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upload binaries to Github Releases? #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
coolaj86 opened this issue Jan 13, 2021 · 7 comments
Open

Upload binaries to Github Releases? #43

coolaj86 opened this issue Jan 13, 2021 · 7 comments

Comments

@coolaj86
Copy link
coolaj86 commented Jan 13, 2021 •
edited
Loading

Would you mind uploading compiled binaries to Github Releases?

It seems like this project is pretty much complete, so it's probably not worth worrying about setting up any sort of automated build process since just one upload every few years would seem to suffice.

Build Instructions

I have some instructions for how to build on Mac and Linux, and I'd be happy to supply binaries for those two (including Apple Silicon M1).
(my process is documented here: https://github.com/coolaj86/fdkaac/releases/tag/v1.0.1-pre-1)

Trustable 1st Party Builds

I realize that I could host these on my own Github page (which I'm doing for a client currently), but I'd like to get this up on Webi (webinstall.dev) as well, and we try to avoid 3rd party builds whenever possible since people generally trust 1st party builds more (and they generally work as documented).
@nu774
Copy link
Owner
nu774 commented Jan 14, 2021

I'm not distributing binary build because of this (quoted from NOTICE of FDK-AAC library):

3.    NO PATENT LICENSE

NO EXPRESS OR IMPLIED LICENSES TO ANY PATENT CLAIMS, including without
limitation the patents of Fraunhofer, ARE GRANTED BY THIS SOFTWARE LICENSE.
Fraunhofer provides no warranty of patent non-infringement with respect to this
software.

You may use this FDK AAC Codec software or modifications thereto only for
purposes that are authorized by appropriate patent licenses.

@coolaj86
Copy link
Author
coolaj86 commented Jan 14, 2021 •
edited
Loading

Yuck.

For some reason I was under the impression that AAC was owned by Apple and that it was royalty free. Maybe that's just m4a... or maybe I just dreamed it up.

Additional resources, for others following:

(Apple isn't even on the list of owners, oddly enough)

@kedaitinh12
Copy link

Here: https://www.mediafire.com/file/09lrxx3gznosk8h/FDK-AAC-1.0.1-Git-2020-11-30_Win_GCC102.7z/file

@Artoria2e5 Artoria2e5 mentioned this issue Apr 21, 2023
Closed
@Artoria2e5
Copy link
Artoria2e5 commented Apr 21, 2023 •
edited
Loading

wrt patents:

  • On one hand, it's probably not as bad as Wikipedia says. FFmpeg is now perfectly happy to link to Windows builds with its own aac codec.
  • On the other, the ffmpeg encoder is old tech (but decoder isn't!), so the timeframe might not align perfectly. FFmpeg takes the easy way though: https://ffmpeg.org/legal.html just says "they probably won't sue you".

The patent terms are funny. It covers encoders and decoders equally. Although FFmpeg does not have the ability to encode all the fancy ELD, HE, whatever stuff, it can decode all of them, and hence should be hit as hard as fdkaac.

@Neustradamus
Copy link

To follow

@Artoria2e5
Copy link

Maybe I can find a stronger argument. Debian is perfectly happy to distribute fdk-aac https://packages.debian.org/source/sid/fdk-aac despite its qualms about the "oh no it's banning people from charging for the code so it's non-free" business. Debian, as in the linux distribution more serious about license issues than the FSF.

@spvkgn
Copy link
spvkgn commented Jun 16, 2024 •
edited
Loading

There is a stripped down version of FDK-AAC https://gitlab.freedesktop.org/wtaymans/fdk-aac-stripped

This fdk-aac fork is stripped from parts with patent concerns (i.e. HE
(High Efficiency) and HEv2 profiles). The Fedora Legal team has approved this
fork. https://bugzilla.redhat.com/1501522

https://repology.org/project/fdk-aac-free/versions

Here is fdkaac built with stripped fdk-aac
fdkaac-1.0.6-x64.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Neustradamus @coolaj86 @nu774 @spvkgn @Artoria2e5 @kedaitinh12 and others
0