8000 Remove NestedLoops from public API · Issue #462 · morelinq/MoreLINQ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Remove NestedLoops from public API #462
Closed
@atifaziz

Description

@atifaziz

As the comment in NestedLoops.cs says…

// This extension method was developed (primarily) to support the
// implementation of the Permutations() extension methods. However,
// it is of sufficient generality and usefulness to be elevated to
// a public extension method in its own right.

…it was really designed for internal use by Permutations and I don't think it went through a proper design review at the time it was submitted so it should have never been public in the first place!

The reason I think it should be removed is that it's not an extension method for a sequence and the Action it extends doesn't have any arguments! Therefore Action must use side-effects to do any useful work and the resulting sequence of results won't be deterministic or will always require memoization.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0