[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Shared subscriptions #449

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

WIP: Shared subscriptions #449

wants to merge 4 commits into from

Conversation

robertsLando
Copy link
Member

Based on discussion: #437 (comment)

@github-actions
Copy link

Pull Request Test Coverage Report for Build 820a2b5a8795777893b27dd4dcd1a9f3701a1611-PR-449

  • -23 of 33 (30.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.6%) to 96.082%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/handlers/unsubscribe.js 2 5 40.0%
lib/utils.js 0 3 0.0%
lib/handlers/subscribe.js 6 14 42.86%
lib/client.js 1 10 10.0%
Totals Coverage Status
Change from base Build fc45bc6cc9bbf01443e6670f2c593dcd280bf20b: -3.6%
Covered Lines: 767
Relevant Lines: 790
💛 - Coveralls

@robertsLando robertsLando mentioned this pull request Feb 24, 2020
Open
@robertsLando robertsLando requested review from mcollina and gnought and removed request for mcollina February 24, 2020 14:09
@robertsLando
Copy link
Member Author

@gnought This is just an idea about how we could implement this

@gnought gnought marked this pull request as draft April 9, 2020 12:09
@r3na
Copy link
Contributor
r3na commented Aug 31, 2020

Is this PR still valid? It would be very useful to have it implemented

@robertsLando
Copy link
Member Author

@r3na This requires some work also in persistences

@hudson-bruno
Copy link
hudson-bruno commented Feb 22, 2021 •
edited
Loading

Any updates? This is such a powerful feature

@robertsLando
Copy link
Member Author

Actually nope

@roysG
Copy link
roysG commented Dec 2, 2021

Any Update??

@robertsLando
Copy link
Member Author

No

This was referenced May 2, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnought gnought Awaiting requested review from gnought

@mcollina mcollina Awaiting requested review from mcollina

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertsLando @r3na @hudson-bruno @roysG