8000 Cannot use DebugType=embedded in normal csproj · Issue #19066 · mono/mono · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cannot use DebugType=embedded in normal csproj #19066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Therzok opened this issue Feb 27, 2020 · 6 comments
Closed

Cannot use DebugType=embedded in normal csproj #19066

Therzok opened this issue Feb 27, 2020 · 6 comments
Assignees
@radical
Labels
area-Tools: msbuild

Comments

@Therzok
Copy link
Contributor
Therzok commented Feb 27, 2020

Steps to Reproduce

  1. Create a project
  2. Assign DebugType to embedded
  3. Observe portable is written

Current Behavior

Microsoft.CSharp.Mono.targets overrides the DebugType value.

Expected Behavior

It should let either embedded or portable be valid options.

On which platforms did you notice this

[*] macOS
[ ] Linux
[ ] Windows

Version Used:

➜  ~ mono --version
Mono JIT compiler version 6.10.0.87 (2019-12/b33fa1d00ed Wed Feb 26 21:46:15 EST 2020)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
	TLS:
	SIGSEGV:       altstack
	Notification:  kqueue
	Architecture:  amd64
	Disabled:      none
	Misc:          softdebug
	Interpreter:   yes
	LLVM:          yes(610)
	Suspend:       hybrid
	GC:            sgen (concurrent by default)

Workarounds

If you set the DebugType in a targets file that's imported after the Mono one, you can successfully build with embedded PDBs.
@Therzok
Copy link
Contributor Author
Therzok commented Feb 27, 2020

cc @radical @marek-safar

@marek-safar
Copy link
Member

The problem is in the msbuild target where we force to override everything to portable this is wrong.

/cc @radical

@radical
Copy link
Member
radical commented Feb 27, 2020

We needed to do that earlier. If embedded works fine now, then we can remove the override. What branches should this be done for?

@Therzok
Copy link
Contributor Author
Therzok commented Feb 27, 2020

The fix for embedded pdbs is in master, 2020-02, 2019-12.

@radical radical self-assigned this Feb 27, 2020
@radical
Copy link
Member
radical commented Feb 27, 2020 •
edited
Loading

Waiting on:

@radical
Copy link
Member
radical commented Mar 3, 2020

All the PRs have been merged.

@radical radical closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radical radical

Labels
area-Tools: msbuild
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@radical @Therzok @marek-safar
0