Add quarter 'q' to format string #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Couple of quick adjustments because you're also publicly exposing
If you make those changes, I'll merge this. |
|
And see my comment here on Q vs q |
|
ok I will add the change you suggest. |
|
I changed the name from quarterOfYear() to quarter() and I added a new library test. |
icambron
added a commit
that referenced
this pull request
Nov 26, 2013
Add quarter 'q' to format string
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a 'q' to the format string that will output the quarter.
January - March will output 1.
April - June will output 2.
July - September will output 3.
October - December will output 4.
I added a test in format.js called "quarter formats"