8000 Unit tests failing: 146. calendar last week 10 passed,5 failed. · Issue #195 · moment/moment · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unit tests failing: 146. calendar last week 10 passed,5 failed. #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub
8000

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amichal opened this issue Mar 8, 2012 · 5 comments
Closed

Unit tests failing: 146. calendar last week 10 passed,5 failed. #195

amichal opened this issue Mar 8, 2012 · 5 comments
Labels
Unit Test Failed

Comments

@amichal
Copy link
amichal commented Mar 8, 2012

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_3) AppleWebKit/535.11 (KHTML, like Gecko) Chrome/17.0.963.66 Safari/535.11
Eastern Standard Time

146. calendar last week 10 passed,5 failed.
Today - 2 days current time
AssertionError: Today - 2 days current time
    at Object.equal (http://momentjs.com/js/tests.js?_=120203_183019:1526:39)
    at http://momentjs.com/js/tests.js?_=120203_183019:4653:18
    at Object.runTest (http://momentjs.com/js/tests.js?_=120203_183019:1702:9)
    at http://momentjs.com/js/tests.js?_=120203_183019:1748:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1006:13
    at http://momentjs.com/js/tests.js?_=120203_183019:616:13
    at http://momentjs.com/js/tests.js?_=120203_183019:627:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1008:17
    at http://momentjs.com/js/tests.js?_=120203_183019:1589:17
Today - 2 days beginning of day
Today - 2 days end of day
Today - 3 days current time
AssertionError: Today - 3 days current time
    at Object.equal (http://momentjs.com/js/tests.js?_=120203_183019:1526:39)
    at http://momentjs.com/js/tests.js?_=120203_183019:4653:18
    at Object.runTest (http://momentjs.com/js/tests.js?_=120203_183019:1702:9)
    at http://momentjs.com/js/tests.js?_=120203_183019:1748:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1006:13
    at http://momentjs.com/js/tests.js?_=120203_183019:616:13
    at http://momentjs.com/js/tests.js?_=120203_183019:627:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1008:17
    at http://momentjs.com/js/tests.js?_=120203_183019:1589:17
Today - 3 days beginning of day
Today - 3 days end of day
Today - 4 days current time
AssertionError: Today - 4 days current time
    at Object.equal (http://momentjs.com/js/tests.js?_=120203_183019:1526:39)
    at http://momentjs.com/js/tests.js?_=120203_183019:4653:18
    at Object.runTest (http://momentjs.com/js/tests.js?_=120203_183019:1702:9)
    at http://momentjs.com/js/tests.js?_=120203_183019:1748:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1006:13
    at http://momentjs.com/js/tests.js?_=120203_183019:616:13
    at http://momentjs.com/js/tests.js?_=120203_183019:627:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1008:17
    at http://momentjs.com/js/tests.js?_=120203_183019:1589:17
Today - 4 days beginning of day
Today - 4 days end of day
Today - 5 days current time
AssertionError: Today - 5 days current time
    at Object.equal (http://momentjs.com/js/tests.js?_=120203_183019:1526:39)
    at http://momentjs.com/js/tests.js?_=120203_183019:4653:18
    at Object.runTest (http://momentjs.com/js/tests.js?_=120203_183019:1702:9)
    at http://momentjs.com/js/tests.js?_=120203_183019:1748:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1006:13
    at http://momentjs.com/js/tests.js?_=120203_183019:616:13
    at http://momentjs.com/js/tests.js?_=120203_183019:627:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1008:17
    at http://momentjs.com/js/tests.js?_=120203_183019:1589:17
Today - 5 days beginning of day
Today - 5 days end of day
Today - 6 days current time
AssertionError: Today - 6 days current time
    at Object.equal (http://momentjs.com/js/tests.js?_=120203_183019:1526:39)
    at http://momentjs.com/js/tests.js?_=120203_183019:4653:18
    at Object.runTest (http://momentjs.com/js/tests.js?_=120203_183019:1702:9)
    at http://momentjs.com/js/tests.js?_=120203_183019:1748:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1006:13
    at http://momentjs.com/js/tests.js?_=120203_183019:616:13
    at http://momentjs.com/js/tests.js?_=120203_183019:627:25
    at http://momentjs.com/js/tests.js?_=120203_183019:1008:17
    at http://momentjs.com/js/tests.js?_=120203_183019:1589:17
Today - 6 days beginning of day
Today - 6 days end of day
@timrwood
Copy link
Member
timrwood commented Mar 9, 2012

Hmm, that's really weird.

I'm not able to reproduce the issue, can you run the tests again and see if you get the same results? What time did you run the original tests?

@amichal
Copy link
Author
amichal commented Mar 9, 2012

Got a chance to try again. They all pass now.

The failures where around 1am local time. A few minutes before I posted the issue. According to github i posted it at 2012-03-07T22:25:11-08:00 aka 2012-03-08T01:25:11-05:00.

@timrwood
Copy link
Member

Hmm, thats strange.

I'm going to mark this as closed, and if I'm able to reproduce it sometime, I'll reopen it. Thanks for reporting though!

@amichal
Copy link
Author
amichal commented Mar 13, 2012

I'm going to mark this as closed, and if I'm able to reproduce it sometime, I'll reopen it. Thanks for reporting though!

No problem. Your unit test page made that part easy. Only suggestion
that might make it even easier is to include a copy and paste blob
of text for the issue in the unit test page since it knows the
relevant details at the time it is rendered. Would certainly file that
under "nice to have" however.

-AM

@timrwood
Copy link
Member

Thanks for the suggestion, I've added a block of text with user agent, and some relevant timezone information for easy copying and pasting.

@timrwood timrwood mentioned this issue Mar 23, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Unit Test Failed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amichal @timrwood @mattjohnsonpint
0