8000 Handle wrongly cloned moments by ichernev · Pull Request #1417 · moment/moment · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Handle wrongly cloned moments #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 14, 2014
Merged

Handle wrongly cloned moments #1417

merged 5 commits into from
Jan 14, 2014

Conversation

ichernev
Copy link
Contributor

This is in response to #1404

  • detect moment objects that were cloned with something like _.extend({}, moment()) as isMoment-s
  • properly clone them and produce orthodox moment objects

Please interested parties (@chilversc, @mattbrooks2010, @RomanDidenko) -- test on knockout, or whatever fancy libraries you happen to use if it works fine with them.

@RomanDidenko
Copy link

I've tested changes on my functionality and had no issues anymore.

Thanks for the commit.

@mattbrooks2010
Copy link

I tested these changes using Knockout's ko.toJSON(...). The following works:

ko.toJSON(moment());

However, the following still results in the same RangeError as before:

ko.toJSON(moment.utc());

I've included the call stack in case it is any help.

RangeError: Maximum call stack size exceeded
    at moment (RangeError: Maximum call stack size exceeded
    at moment (moment.js:1576:9)
    at Object.extend.clone (moment.js:1756:20)
    at Object.extend.toString (moment.js:1768:25)
    at RegExp.exec (native)
    at makeDateFromInput (moment.js:1403:39)
    at makeMoment (moment.js:1565:13)
    at moment (moment.js:1576:16)
    at Object.extend.clone (moment.js:1756:20)
    at Object.extend.toString (moment.js:1768:25)
    at RegExp.exec (native) moment.js:1576:9)
    at Object.extend.clone (moment.js:1756:20)
    at Object.extend.toString (moment.js:1768:25)
    at RegExp.exec (native)
    at makeDateFromInput (moment.js:1403:39)
    at makeMoment (moment.js:1565:13)
    at moment (moment.js:1576:16)
    at Object.extend.clone (moment.js:1756:20)
    at Object.extend.toString (moment.js:1768:25)
    at RegExp.exec (native)

@ichernev
Copy link
Contributor Author

@mattbrooks2010 yeah. I missed moment.utc. Now it works, I tested with ko and added tests.

@mattbrooks2010
Copy link

Confirmed - thank you. Do you know when a release will be available via NuGet?

icambron added a commit that referenced this pull request Jan 14, 2014
@icambron
Merge pull request #1417 from ichernev/bugfix/cloning-weird-moments
b0a23c9 
Handle wrongly cloned moments
@icambron icambron merged commit b0a23c9 into moment:develop Jan 14, 2014
@icambron
Copy link
Member

Looks great

8F51
@ichernev ichernev mentioned this pull request Jan 17, 2014
Closed
@ichernev ichernev mentioned this pull request Jun 5, 2014
Closed
@theurere theurere mentioned this pull request Jul 1, 2014
Merged
@kkirsche kkirsche mentioned this pull request Feb 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ichernev @RomanDidenko @mattbrooks2010 @icambron
0