10000 MODExt Grid column editor tooltips are displayed even the config option editable is disabled · Issue #16507 · modxcms/revolution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MODExt Grid column editor tooltips are displayed even the config option editable is disabled #16507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
revocarne opened this issue Jan 5, 2024 · 0 comments
Open

MODExt Grid column editor tooltips are displayed even the config option editable is disabled #16507

revocarne opened this issue Jan 5, 2024 · 0 comments
Labels
bug The issue in the code or project, which should be addressed.

Comments

@revocarne
Copy link

Bug report

Summary

In a grid, the icon pen is displayed even the config options editable is disabled.
It’s really unpleasant when for developing a CMP.

Step to reproduce

Still when disable the config options editable in a column.

Observed behavior

Easy to fix the "bug"
In the file "revolution/manager/assets/modext/widgets/core/modx.grid.js" line 475 and 1176

replace "if (c[i].editor) {"
by : "if (c[i].editor && c[i].editable) {"

Expected behavior

Environment

All
@revocarne revocarne added the bug The issue in the code or project, which should be addressed. label Jan 5, 2024
@smg6511 smg6511 mentioned this issue Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@revocarne
0