-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Windows: Support named pipe mounts in docker service create + stack yml #34795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Support named pipe mounts in docker service create + stack yml #34795
Comments
OK, running Docker engine with debug output.
Seems to be the same problem:
Here is the output of
|
/cc @johnstep |
The Docker 17.10.0-ee-preview-2 also has this problem, at least it shows the problem much easier
Seems like |
Yup, we have to fix this... |
I opened docker/cli#560 to fix the docker-cli parsing, but there will still need to be another fix on the server side I believe, since it's also broken for |
What is status of this one? Partly fixed but not fully yet? |
This still doesn't work in 18.03.1-ee-1 |
I already started to implement exceptions for npipe to bind mount but when read #33852 more carefully I noticed that it have actually added new mount type npipe. It means that mount command like this is already valid:
That is just missing from documentation: https://docs.docker.com/engine/reference/commandline/service_create/#add-bind-mounts-volumes-or-memory-filesystems If I try to create service with command like this:
it gives error:
So correct way to fix this is:
I will look it. |
A little sad that you have to provdide the full UNC path for the pipe, with |
Any update on this topic? |
@deviantony I have implemented fix to this. Status is that moby/swarmkit#2691 is waiting for review. Why it is not reviewed yet. I have no idea. |
Still an issue in: |
@dazinator only possible workaround is create containers using docker run command. Permanent solution is merge moby/swarmkit#2691 and related PRs but unfortunately I don't know why swarm team have not been able to do that. |
@yongtang sorry about confusing info but #37400 actually only fixed npipe mounting with docker service create command but using npipe on stack files does not work before docker/cli/pull/1195 have been merged and updated to moby. |
Let me reopen until docker/cli#1195 is merged (which completes the cycle) |
|
@amivit you need update server version. Old Win 2016 does not support that. Look: portainer/portainer#2299 |
Have any plan release to Docker EE Engine? |
@kkbruce some discussion about release for CE and EE is on here: moby/swarmkit#2691 (comment) |
Any update? Still the same problem on Docker EE 18.09.2 |
@mgiangrandi can you explain what "the same problem" is? What error are you seeing? |
@mgiangrandi feature is not yet released. It will be part of 19.03. |
When is 19.03 planned for release? According to the name, it looks like it was planned for last month? |
preliminary dates are mentioned in this milestone; https://github.com/docker/docker-ce/milestone/32 |
Anyone knows why 19.03 hasnt been release yet? its overdue for 5 days and completed 100% Thank you |
Running 19.03.2 and it appears to still be broken |
@michaelandsylas234 earlier implementation was missing. Now it is implemented, tested and released. If it does not work on certain conditions it is bug so plz create issue with full details about how it can be reproduced. |
Uh oh!
There was an error while loading. Please reload this page.
Description
I try #33852 to map the Docker engine's named pipe
\\.\pipe\docker_engine
into a service, but fail using it in a stack yml.Steps to reproduce the issue:
notepad insider.yml
docker stack deploy -c insider.yml whoami
Describe the results you received:
Describe the results you expected:
Docker Stack yml should also support the named pipe mounts..
Additional information you deem important (e.g. issue happens only occasionally):
Creating a service with
docker service create
seems to do it, but I haven't verified if the named pipe works inside the service. No error message, but no replica will be started for that service. I'll open another issue when I have more details.I also tried
docker-compose
, but had a similar issue docker/compose#5181Output of
docker version
:Output of
docker info
:Additional environment details (AWS, VirtualBox, physical, etc.):
HyperV VM running in Azure
The text was updated successfully, but these errors were encountered: