Using `functools.wraps` #35

galou · 2025-05-07T06:33:08Z

galou
May 7, 2025

I just discovered functools.wraps. Could it be used in fcapi?

For example:

diff --git a/fpo.py b/fpo.py
index d44a038..dc2c796 100644
--- a/fpo.py
+++ b/fpo.py
@@ -43,6 +43,7 @@ import traceback
 from collections.abc import Callable
 from dataclasses import dataclass
 from enum import Enum, IntEnum
+from functools import wraps
 from pathlib import Path
 from typing import (
     TYPE_CHECKING,
@@ -401,12 +402,10 @@ def _t_forward(cls: type, forward_from: str, forward_to: str) -> None:
     forward = getattr(cls, forward_to, None)
     if forward:
 
+        @wraps(forward)
         def handler(self: Any, *args: tuple, **kwargs: dict) -> Any:
             return forward(self, *args, **kwargs)
 
-        handler.__signature__ = inspect.signature(forward)
-        handler.__doc__ = forward.__doc__
         handler.__name__ = forward_from
         setattr(cls, forward_from, handler)

I didn't test this yet.

mnesarco · 2025-05-07T14:15:01Z

mnesarco
May 7, 2025
Maintainer

Yes I use it in other APIs. _t_forward is a special case because it is a redirect more than a plain forward, but wraps can handle part of the typing. wraps is very helpful when the function is returned because it helps the linter/code completion (not in this case unfortunately)

So my opinion is that yes, it can be used, but in this specific method it adds nothing special.

1 reply

galou May 9, 2025
Author

Thanks for the explanation!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Using `functools.wraps` #35

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment 1 reply

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Using functools.wraps #35

Uh oh!

galou May 7, 2025

Replies: 1 comment · 1 reply

Uh oh!

mnesarco May 7, 2025 Maintainer

Uh oh!

galou May 9, 2025 Author

Using `functools.wraps` #35

galou
May 7, 2025

Replies: 1 comment 1 reply

mnesarco
May 7, 2025
Maintainer

galou May 9, 2025
Author