8000 Comparing vaadin:main...mletenay:main · vaadin/flow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vaadin/flow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: mletenay/flow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 5 files changed
  • 1 contributor

Commits on Jul 8, 2024

  1. Avoid unnecessary/duplicate invocations of Component:getUI

    Component.getUI is potentially expensive operation, especially in
    complex UIs with deep component tree, since it traverses up to the root
    component.
    
    Do not unnecessarily invoke it multiple times like getUI().isPresent() +
    getUI().get(), but rather use local variable to avoid repeated component
    tree traversal.
    
    Change-Id: Ideb3619899e55904de670ee17624d2ca91ba22b7
    mletenay committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    431e037 View commit details
    Browse the repository at this point in the history
  2. Fix source code formatting

    Fix source code formatting
    
    Change-Id: I95d775fb81e074db8ca4429168cd2479a925365a
    mletenay committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2fb5ace View commit details
    Browse the repository at this point in the history
  3. Use Optional::map to make to code more concise.

    Use Optional::map to make to code more concise/readable.
    
    Change-Id: I29b71f740c287bfeb89c97b29203ab47930df4ab
    mletenay committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    425b07b View commit details
    Browse the repository at this point in the history
  4. Fix source code formatting

    mletenay committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6c236ca View commit details
    Browse the repository at this point in the history
Loading
0