setting response header after content stream is read? #72

nicholascloud · 2015-04-10T01:05:19Z

I'm implementing a middleware that will set the Content-MD5 header (https://tools.ietf.org/html/rfc1864). This requires the full content of the response body to be read and then hashed. I'm trying to implement this by piping the content stream via through, but the Content-MD5 response header never makes it to the client. What would be the best way to go about this? My attempt is below.

'use strict';
var crypto = require('crypto');
var through = require('through');

function contentMD5(app, options) {
  return function (conn) {
    var md5sum = crypto.createHash('md5');
    return conn.call(app).then(function () {
      var response = conn.response;
      var headers = response.headers;

      response.content = response.content.pipe(through(function write (data) {
        md5sum.update(data);
        this.emit('data', data);
      }, function end () {
        var digest = md5sum.digest('hex');
        console.log('>>> here', digest);
        headers['Content-MD5'] = digest;
        this.emit('end');
      }));
    });
  };
}

module.exports = contentMD5;

The text was updated successfully, but these errors were encountered:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

setting response header after content stream is read? #72

setting response header after content stream is read? #72

setting response header after content stream is read? #72

setting response header after content stream is read? #72

Comments