8000 Benchmark comparison with Go stdlib · Issue #32 · minio/blake2b-simd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 26, 2018. It is now read-only.

Benchmark comparison with Go stdlib #32

Open
agnivade opened this issue Feb 8, 2018 · 3 comments
Open

Benchmark comparison with Go stdlib #32

agnivade opened this issue Feb 8, 2018 · 3 comments
Assignees
Labels

Comments

@agnivade
Copy link
agnivade commented Feb 8, 2018

Hi,

Looking at the Go source code, it also has AVX2 support - https://github.com/golang/crypto/blob/master/blake2b/blake2bAVX2_amd64.s.

But the benchmarks here show considerable difference -
https://github.com/minio/blake2b-simd#avx2

I could not find the code which generates benchmarks for Go and this library. Are the benchmarks outdated ? Is there a reason to choose this library over the Go one ?

@fwessels
Copy link
Contributor
fwessels commented Feb 8, 2018

The benchmarking code is in https://github.com/minio/blake2b-simd/blob/master/benchmarks_test.go.

Since we did the benchmark there have been development in Golang (stdlib) so, given some spare time, it would be good to redo the benchmarks.

@agnivade
Copy link
Author
agnivade commented Feb 9, 2018

Please correct me if I am wrong, but that file just compares the different hash methods. It does not compare BLAKE2b Go vs this repo.

@fwessels
Copy link
Contributor
fwessels commented Feb 9, 2018

You are correct, was a bit too quick there.

We will have modified these benchmark tests and captured the results in consecutieve runs in order to compare between old and new (and also avoid a naming clash by including two blake2b’s).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
0