-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request : Navigation Bar like Visual Studio or Eclipse #9418
Comments
@gfrancischini your link to some image does not work. |
|
I have looked at the available services and API --- it's definitely doable. Key points are
The only remaining question is placing the navbar on screen. I'm not quite sure which part of the code has the layout of editor tabs. One way or another I'm preparing to have a go at this feature. Any preliminary advice and suggestions are welcome! |
Opened PR #31162 with a prototype implementation, using services described above. Advice on finalising the styles, and coding changes is highly appreciated! |
Updated PR #31162 with flashing symbol position, adding screenshot here too. Does it look good? Any feedback? |
This feature request will not be considered in the next 6-12 months roadmap and has been closed to keep the number of issues we have to maintain manageable. See also our issue reporting guidelines. Thanks for your understanding and happy coding! |
@isidorn Why did you close this? Since when do you take responsibilities in this area? |
@jrieken I went through all the UX issues because I felt there are a lot of issues that nobody payed attention to. Feel free to reopen. I closed it because I thought it is out of scope and that we would not do it in the next year. |
It's on our roadmap: https://github.com/Microsoft/vscode/wiki/Roadmap#workbench |
Ah that's true!
It was a bit disheartening to see this dropped, but to be honest my own effort fell silent for a while (backlog at day job) so I didn't have courage to complain. Thanks for raising profile of this feature @jrieken , I'll push with what's been discussed on the prototype implementation thread next week. Hope no hard feelings, this is a huge project and admin friction is sometimes inevitable. Microsoft is doing stellar job managing community contribution on VSCode as well as relevant sister projects. Thank you! |
This is nice and very handy, i had the same "pain" for long functions, where i don't know where i'm :) , it would be nice to read the stycky function name on the scroll page scope. Like the referenced issue shows above! |
I'd also like to add that structure breadcrumbs/path can be very useful for nested data formats like JSON or XML. IntelliJ and Chrome Dev Tools provide this. For instance, when I'm looking at a giant Elasticsearch document or mapping dump where key names are re-used at different levels, it's invaluable to see that i'm on, say
These breadcrumbs can get very long, so being able to scroll horizontally over them or being able to copy the path to the currently highlighted node is very useful. |
A first version of this is in todays insiders build. You can enable it via Tabs & Breadcrumbs No Tabs & Breadcrumbs Keybindings You can use the mouse and these keybinding to interact with breadcrumbs
Remember, this is an early version and not yet everything works e.g. type to find. Still, give it a try and let us know what you think. #HappyCoding! |
Can we have an option to hide the file path which I'm not interested in? It becomes very crowded very quickly when multiple columns of editors are open. |
Yeah, the following things I have in my mind: |
@jrieken: This is the best solution! 💯 |
Is it populated with the data the outline view uses? |
Awesome work!! Suggestion for click/hover at breadcrumb: main function instead of popping up menus should be to jump to the symbol location. The main feature of breadcrumbs is to find way in a convoluted mess of text. Building mental map of what's where in the text is the key to that, and that's where breadcrumb linking to positions in text help a lot: "this one is here (pointing), and that one is there (pointing)". Correction: why not make Another suggestion: move [Find] field down below, or remove completely. It makes interaction less smooth Another: when too many crumbs, collapse leading ones to fit on screen - currently overflows and hides trailing |
Awesome stuff. Could it also highlight errors like Code Outline as well? |
👍 pushed a change to make Cmd/Ctrl+Click reveal the symbol in the editor. Also Shift+Enter will reveal the symbol instead of showing the picker. Updated my comment above accordingly. |
How does the user know he can type to filter? Is there a tooltip or an icon or the like? Any hint? |
Is there an action which I can bind to open up the topmost dowpdown? I'd like to use this to close #53279 by allowing a quick way to navigate from say Edit: Missed the comment above. Looks good! |
Fair question. I guess it depends on your expectations, may users are used to typing in a tree doing the right thing and miss it from other trees. Those might intuitively start to type, others might need some education... |
It would be nice if the crumbs could be optionally hidden by default and only appear on the |
Closing this issue now because the biggest chunk of work is done and because we will ship this with the July release. Obviously, we aren't done but in the name of manageability we have added the |
Would be possible to add a navigation bar like visual studio or eclipse?
Feature Navigation Bar -
This bar should show function/methods of the current file.
I know that vscode support the ctrl + p + # to find symbols but this approach is not the best when you want to have a look over the entire class (or perhaps you dont know the method name)
The text was updated successfully, but these errors were encountered: