-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not continuously prompt User to download Java Extension from Microsoft #136301
Comments
Does the gear wheel button offer you any further options? |
Ah, we have always 'deleted' the button using 'x'. Tried the Gear and picked don't recommend again and it seems to have stopped. I will ask some others to try it. Related question: is there an API Graal Team can call to disable this prompt altogether when we install Graal Tool for Java VS Code Extension. Very confusing for the developer |
Can you please check what extensions this is recommending? And do you have those recommended extensions installed? |
When I am building a java-based application, I want to use Graal Tools for Java Extension. But, whenever, I create a new java file, VS Code is recommending Microsoft's Java Extension (which is not right since I already downloaded Graal Extension). and no, I don't have or want to install MS's Java Extension (and all other ancilillary stuff it downloads). Please speak with Rome.Li@microsoft.com who has fuller context. |
Got it. May be we shall not recommend the language extension which we configured in the product, if user has already installed another extensions supporting the language. @isidorn @chrisdias what do you think? |
@sandy081 I think that makes sense in general. |
Mentioned similar in my feature request here: #136644 Having a settings option to just completely disable 'pack recommendations' would be nice/ideal. It's also sad to see this is basically just pushing Microsoft stuff. Kind of anti-competitive to other devs making useful extensions for things. |
@isidorn How long will VS Code seek input before executing on a plan to address the original issue raised? Thanks, Alok |
Sadly, I don't think we'll see them actually fix this and will eventually be up to a third-party developer to make a 'block' for nonsense additions like this. If you check out my issue linked above, they completely derailed the conversation into something else and ignored my original post pretty much entirely. It seems they are more interested in getting people to install as many Microsoft branded extensions as possible than to actually support the third-party community that made this tool what it is today. |
This has only been open for 1 month. We are still waiting for additional user feedback. |
Care to link to the discussions that were had to have this feature implemented in the first place? Doesn't seem like there are any for it to be added and then not even given the option to disable it without just fully disabling all suggestions. |
This behaviour is very annoying, can the priority on this one be increased please? It is painful to be continuously hassled to install plugins I do not want |
Currently, GraalVM Tools for Java still automatically disables core features of Extension Pack for Java if both extension packs are present. Since two extension packs might have their specific scenarios, for example, Spring users still need to install the Extension Pack for Java for Spring development, simply disabling features in another extension doesn't seem the correct course of action. It's very likely to for a user to two install both extensions for different purposes. I'm a bit skeptical about the automatic suppression of GraalVM Tools for Java. Do you know when this issue can be addressed? Thanks |
@nickzhums I think we need a recommendation on how to deal with this. Clearly the two extensions cannot be used at the same time so is there a way allow the user to choose one on a per workspace basis? Are there APIs for this? We need to know how this can be addressed and of course will address it. Note I think it will also need to be addressed on the VSCode for Java side since if if the user chooses to use GraalVM Tools for Java then they shouldn't be prompted or continuously hassled to use another extension. |
Thank you very much for your feedback. |
We have pushed a fix for this. Please try it out from VS Code insiders on Monday and let us know how it goes. |
Thank you! |
Wonderful, thank you!
…On Fri, Feb 11, 2022 at 2:15 AM Graeme Rocher ***@***.***> wrote:
Thank you!
—
Reply to this email directly, view it on GitHub
<#136301 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOP24VCPAM5TS5CXESMSSH3U2TOUHANCNFSM5HG6LYCQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Mobile: 425-208-1132
LinkedIn: http://www.linkedin.com/in/alokkumarsinha
|
To verify:
|
We have. It works!
…On Tue, Feb 22, 2022 at 2:45 AM Sandeep Somavarapu ***@***.***> wrote:
To verify:
- Open VS Code (use fresh user data and extensions data directory)
- Install ASF.apache-netbeans-java extension
- Create a java file
- Make sure there is no recommendation to install Java Extension Pack
- Uninstall ASF.apache-netbeans-java extension and reload window
- Create a java file
- Make sure there is a recommendation to install Java Extension Pack
—
Reply to this email directly, view it on GitHub
<#136301 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOP24VF4YVHYT6WXQK3N7I3U4OAPBANCNFSM5HG6LYCQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Mobile: 425-208-1132
LinkedIn: http://www.linkedin.com/in/alokkumarsinha
|
Great, thanks @alokkumarsinha |
Does this issue occur when all extensions are disabled?: Yes/No
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: