8000 RPC errors should lead to FAILURE termination · Issue #29 · metricq/metricq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

RPC errors should lead to FAILURE termination #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tilsche opened this issue May 3, 2019 · 2 comments
Open

RPC errors should lead to FAILURE termination #29

tilsche opened this issue May 3, 2019 · 2 comments
Labels
lang:python Concerns the Python interface

Comments

@tilsche
Copy link
Contributor
tilsche commented May 3, 2019

Errors in RPC handling (Connection::handle_management_message) should cause all clients to stop with EXIT_FAILURE. We somehow need to pass that to the outside distinguishable from sporadic connection issues.

We may need to distinguish. The most common issues are json::parse_error or json::type_error due to invalid configurations. At least that isn't going to fix itself by restarting.
@tilsche tilsche added the lang:c++ Concerns the C++ interface label May 3, 2019
@tilsche tilsche added the lang:python Concerns the Python interface label Sep 3, 2019
@tilsche
Copy link
Contributor Author
tilsche commented Sep 3, 2019

turns out it also affects python sources (esp. RPC timeouts)

This was referenced Jun 26, 2020
Closed
Closed
@bmario bmario removed the lang:c++ Concerns the C++ interface label Jul 10, 2020
@bmario
Copy link
Member
bmario commented Jul 10, 2020 •
edited
Loading

Fixed for c++ in metricq/metricq-cpp#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang:python Concerns the Python interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmario @tilsche
0