8000 Request to be merged into Home-Assistant Core · Issue #11 · meichthys/uptime_kuma · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Request to be merged into Home-Assistant Core #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
meichthys opened this issue Aug 30, 2022 · 6 comments
Open

Request to be merged into Home-Assistant Core #11

meichthys opened this issue Aug 30, 2022 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@meichthys
Copy link
Owner

@m1ckyb Would you be willing to help get this merged into core?
@m1ckyb
Copy link
Collaborator
m1ckyb commented Aug 30, 2022

I'm not really that good at that, can try and help..

@meichthys
Copy link
Owner Author

Oops, i mean't to tag @jayakornk, but feel free to help out where you can 👍

@meichthys meichthys added the help wanted Extra attention is needed label Nov 27, 2022
@pixelrazor
Copy link

Is there any sort of summary of what needs to be done to get this added to core?

@meichthys
Copy link
Owner Author

It needs to be submitted and reviewed. From my experience it's not a pleasant experience since they generally don't allow pull requests with multiple types of sensors, so you'd have to strip mich of the functionality out and then add it back in separate smaller pull requests. They will want tests which can sometimes be ignored. Lots of code changes will be recommended prior to merging. It's a good process to ensure high quality code, but not one I'm wanting to go through again. Any help would be appreciated!

@pixelrazor
Copy link

I think we should switch to that socket API library before that, since it'll be a change in config (user/pass vs key). That or wait for rest API support

@meichthys
Copy link
Owner Author

I have no intentions of trying to merge this myself, but I'd be glad to let someone to take the reigns on this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m1ckyb @meichthys @pixelrazor
0