8000 Run Sorbet in CI · Issue #114 · marcoroth/herb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Run Sorbet in CI #114
Open
Open
@marcoroth

Description

@marcoroth

With #106 we introduced RBS Inline types annotations.

It would be great if we could also use Sorbet to typecheck the codebase. Right now we are blocked because RBS aliases are not supported yet:

$ bundle exec srb tc

lib/herb/errors.rb:21: RBS aliases are not supported https://srb.help/3551
    21 |      #: () -> serialized_error
                       ^^^^^^^^^^^^^^^^

Another detail I noticed is that Sorbet doesn't support the inline type signatures for attr_reader, i.e this doesn't work:

module Herb
  class Position
    attr_reader :line #: Integer
    attr_reader :column #: Integer
  end
end

but this does:

module Herb
  class Position
    #: Integer
    attr_reader :line 

    #: Integer
    attr_reader :column 
  end
end

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0