Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 5 commits
- 121 files changed
- 2 contributors
Commits on May 31, 2023
-
backport: wasm32: Add a
wasm32_unknown_unknown_jsfeature to contro……l use of web APIs. Planning ahead for when WASI is to be supported, require the user to opt into using web APIs for thw wasm32-unknown-unknown target with a new feature, since wasm32-unknown-unknown could be used for either web or non-web environments. Don't bother updating the tests to use this new flag, since the tests aren't part of the "public API" of *ring*. When we add support for other WebAssembly environments (e.g. WASI) we'll update the tests then.
-
backport: Separate
CounterandIvfor AES-CTR & ChaCha20; clarify…… alignment. Ensure we're always passing in u32-aligned values to `GFp_ChaCha20_ctr32`. Get rid of the attempt to abstract away the difference between ChaCha20 and AES-CTR w.r.t. counters and IVs. The abstraction wasn't actually used by any shared code. The AES-CTR (GCM) code does endian conversion in the assembly so endian conversion cannot easily be deferred to later. For ChaCha20, it makes more sense to do endian conversion at the time of `Counter`/`Iv` construction. Despite the slight duplication of logic in having two `Counter` types and two `Iv` types, this is actually a net reduction of code. If we ever have a third implementation of these types we can apply the Rule of Three to factor out the commonality.
-
backport: Add a Rust ChaCha20 implementation.
See the comments in fallback.rs for more details on the origin.
-
Commits on Jun 13, 2023
-
perl should be in PATH nasm should be at ./target/tools/nasm cargo run --manifest-path pregenerate_asm/Cargo.toml
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...main