fix: fix NotchedOutline misalignment #44342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44342--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
requested changes
Nov 11, 2024
There was a problem hiding this comment.
I think it's better to fix the notch legend instead:
diff --git a/packages/mui-material/src/OutlinedInput/NotchedOutline.js b/packages/mui-material/src/OutlinedInput/NotchedOutline.js
index 0dabd05e27..86f75a276f 100644
--- a/packages/mui-material/src/OutlinedInput/NotchedOutline.js
+++ b/packages/mui-material/src/OutlinedInput/NotchedOutline.js
@@ -55,7 +55,7 @@ const NotchedOutlineLegend = styled('legend', { shouldForwardProp: rootShouldFor
whiteSpace: 'nowrap',
'& > span': {
paddingLeft: 5,
- paddingRight: 5,
+ paddingRight: 4,
display: 'inline-block',
opacity: 0,
visibility: 'visible',
While that will be better then main branch right now, I think this change misses the root cause of the unequal spacing. The white fieldset version is still misaligned with the actual label, but now the empty space to the right of real label is not so big. It is an acceptable solution, but I don't quite see how it is better? |
|
Thoughts on this @siriwatknp? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #44341
And may my OCD be satisfied after this.