[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix require context path to avoid duplicate key creation #36083

Open
wants to merge 2 commits into
base: v5.x
Choose a base branch
from
Open

[docs] Fix require context path to avoid duplicate key creation #36083

wants to merge 2 commits into from
+308 −184

Conversation

LukasTy
Copy link
Member
@LukasTy LukasTy commented Feb 6, 2023 •
edited
Loading

Replicate change made in mui/mui-x#7781

In case of this repository, there is no warning being thrown in dev mode, but we can still optimize. 🙈

The only relevant manual change is contained in this commit: ba4c3a9. Everything else is generated.

The result of running console.log(req.keys()); in badge-unstyled.js:
Before:

[
  './badge-unstyled-pt.json',
  './badge-unstyled-zh.json',
  './badge-unstyled.json',
  'docs/translations/api-docs/badge-unstyled/badge-unstyled-pt.json',
  'docs/translations/api-docs/badge-unstyled/badge-unstyled-zh.json',
  'docs/translations/api-docs/badge-unstyled/badge-unstyled.json'
]

After:

[
  './badge-unstyled-pt.json',
  './badge-unstyled-zh.json',
  './badge-unstyled.json'
]

@LukasTy LukasTy added the docs Improvements or additions to the documentation label Feb 6, 2023
@LukasTy LukasTy self-assigned this Feb 6, 2023
@mui-bot
Copy link
mui-bot commented Feb 6, 2023 •
edited
Loading
Messages
📖 Netlify deploy preview: https://deploy-preview-36083--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 7a373d0

oliviertassinari
oliviertassinari reviewed Feb 6, 2023
View reviewed changes
Copy link
Member
@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 2, 2023
@siriwatknp
Copy link
Member

@LukasTy So sorry for the delay, is this PR still fix the issue for the current state of the docs? If yes, can you resolve the conflicts (or create a new PR 😅) and tag me again. I will review it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova Awaiting requested review from mnajdova

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

At least 1 approving review is required to merge this pull request.

Assignees

@LukasTy LukasTy

Labels
docs Improvements or additions to the documentation PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LukasTy @mui-bot @siriwatknp @oliviertassinari