[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme font not applied for React 19 #44677

Open
Nefcanto opened this issue Dec 7, 2024 · 4 comments
Open

Theme font not applied for React 19 #44677

Nefcanto opened this issue Dec 7, 2024 · 4 comments
Assignees
Labels
external dependency Blocked by external dependency, we can’t do anything about it package: material-ui Specific to @mui/material status: waiting for author Issue with insufficient information

Comments

@Nefcanto
Copy link
Nefcanto commented Dec 7, 2024

Steps to reproduce

1- Create a React 19 app (Vite)
2- Import createTheme from @mui/material/styles
3- Import ThemeProvider from @mui/material/styles
4- Wrap the app wit the ThemeProvider
5- Create a custom theme with a custom font name
6- Set that theme as the <ThemeProvider theme={customTheme}
7- That font does not load

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: 19

@Nefcanto Nefcanto added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 7, 2024
@mj12albert
Copy link
Member

@Nefcanto Would you mind providing a repro in CodeSandbox/Stackblitz?

@mj12albert mj12albert added status: waiting for author Issue with insufficient information package: material-ui Specific to @mui/material and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 8, 2024
@Nefcanto
Copy link
Author
Nefcanto commented Dec 8, 2024

@mj12albert, maybe it's related to the Helmet because I see that no font is being loaded in the Networks tab.

I reported it: staylor/react-helmet-async#237

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Dec 8, 2024
@mj12albert mj12albert added external dependency Blocked by external dependency, we can’t do anything about it and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 9, 2024
@mj12albert
Copy link
Member

@Nefcanto Do share a repro if you can so we can rule out issues with material UI as well ~

@Nefcanto
Copy link
Author
Nefcanto commented Dec 9, 2024

@mj12albert, I understand the need for an MRE. But in some cases, like supporting a major dependency version, honesty is not required because everything is clear. I'm against making the path to reporting bugs expensive. If a problem is the outcome of a special way of using a library, and the developers of the library have no idea how to reproduce it, then a repo is a must. But with due respect, for simple cases like this one, asking for repo makes the open-source world a difficult terrain to live in.

@DiegoAndai DiegoAndai added the status: waiting for author Issue with insufficient information label Dec 12, 2024
@DiegoAndai DiegoAndai self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency Blocked by external dependency, we can’t do anything about it package: material-ui Specific to @mui/material status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

3 participants