MetaPetal / GPUImage3 - Implement Video Filters, More Image FIlters #701
Replies: 2 comments 8 replies
-
|
@gintechsystems thanks!) However filters should be customizable. User should have an option to enable/disable any of them. To make postprocessing videos the functional should be placed in one place. It needs refactoring. If you want, you can start doing that. Please use solid architecture, or just separate classes by logic. And finally - make PRs as small as possible. You can make a lot of them. |
Beta Was this translation helpful? Give feedback.
-
|
I understand programmers could, but only what is available or if they create their own YPFilter. What if they don't know how to create one? Know what I mean. I think we should have more to "choose from" from just installing the library. okay sounds good, will do what I can. |
Beta Was this translation helpful? Give feedback.
-
|
" I think we should have more to "choose from" from just installing the library" |
Beta Was this translation helpful? Give feedback.
-
|
Great, maybe for starters we can add customization to allow users to choose what is visible or not (enable / disable). |
Beta Was this translation helpful? Give feedback.
-
|
The way it's implemented with photo filter, I think, is flexible. |
Beta Was this translation helpful? Give feedback.
-
|
I will double check and let you know my thoughts, its been awhile since I looked at this. |
Beta Was this translation helpful? Give feedback.
-
|
In app you can use custom filters. public typealias FilterApplierType = ((_ image: CIImage) -> CIImage?)
public struct YPFilter {
var name = ""
var applier: FilterApplierType?
public init(name: String, coreImageFilterName: String) {
self.name = name
self.applier = YPFilter.coreImageFilter(name: coreImageFilterName)
}
public init(name: String, applier: FilterApplierType?) {
self.name = name
self.applier = applier
}
} |
Beta Was this translation helpful? Give feedback.
-
|
I am not sure how this relates to the original thread? |
Beta Was this translation helpful? Give feedback.
-
Hey guys,
I was thinking of implementing more filters along with the ability to have post processing filters for videos. Thoughts on this? Any reason not to do? I have heard in the past you cannot use instagram filters as they are copyrighted...not sure if possible or even true.
I would like to start adding more filters though outside of the default Apple provides. gintechsystems has done a few PRs to fix other problems in the past (audio / mp4 bugs) with this library and we continue to use it in all projects. It is the best picker out there that is open source!
@NikKovIos @s4cha
Thanks
gintechsystems
Beta Was this translation helpful? Give feedback.
All reactions