updating board files to 2024.1 tools #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a9922b to
35acd68
Compare
mariodruiz
approved these changes
Apr 8, 2025
| @@ -1,40 +1,4 @@ | |||
|
|
|||
| ############################################################################### | |||
| # Copyright (c) 2016-2021, Xilinx, Inc. | |||
| # SPDX-License-Identifier: BSD-3-Clause | |||
There was a problem hiding this comment.
Please do not remove copyright and license.
|
|
||
| # Create instance: spi_shared, and set properties | ||
| set spi_shared [ create_bd_cell -type ip -vlnv xilinx.com:ip:axi_quad_spi:3.2 spi_shared ] | ||
| set_property -dict [ list \ | ||
| CONFIG.C_USE_STARTUP {0} \ | ||
| CONFIG.C_USE_STARTUP_INT {0} \ |
There was a problem hiding this comment.
is this CONFIG.C_USE_STARTUP_INT property not needed?
| @@ -23,6 +23,7 @@ set_property platform.design_intent.external_host "false" [current_project] | |||
| set_property platform.design_intent.datacenter "false" [current_project] | |||
|
|
|||
| # call implement | |||
| set_property strategy Performance_Auto_1 [get_runs impl_1] | |||
There was a problem hiding this comment.
Do we need a different strategy?
mariodruiz
reviewed
Apr 8, 2025
| @@ -1,41 +1,4 @@ | |||
|
|
|||
| ############################################################################### | |||
| # Copyright (c) 2016-2021, Xilinx, Inc. | |||
There was a problem hiding this comment.
Keep license and Copyright
| @@ -1,6 +1,3 @@ | |||
| # Copyright (C) 2022 Xilinx, Inc | |||
| @@ -1,43 +1,3 @@ | |||
| ############################################################################### | |||
| # Copyright (c) 2016-2021, Xilinx, Inc. | |||
| @@ -1,38 +1,3 @@ | |||
| ############################################################################### | |||
| # Copyright (c) 2016-2021, Xilinx, Inc. | |||
| @@ -1,6 +1,3 @@ | |||
| # Copyright (C) 2022 Xilinx, Inc | |||
| @@ -1,32 +1,4 @@ | |||
|
|
|||
| ############################################################################### | |||
| # Copyright (c) 2018-2022, Xilinx, Inc. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.