8000 fix(menu-item): handle menu-item getting checked synchronously (VIV-2352) by RichardHelm · Pull Request #2164 · Vonage/vivid-3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu-item): handle menu-item getting checked synchronously (VIV-2352) #2164

Merged
merged 4 commits into from
Feb 25, 2025
Merged

fix(menu-item): handle menu-item getting checked synchronously (VIV-2352) #2164

merged 4 commits into from
Feb 25, 2025

Conversation

RichardHelm
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link
codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (3f6a8af).
Report is 1303 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##              main     #2164      +/-   ##
============================================
  Coverage   100.00%   100.00%              
============================================
  Files          123       353     +230     
  Lines         1562     16219   +14657     
  Branches       108      2915    +2807     
============================================
+ Hits          1562     16219   +14657
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TaylorJ76
TaylorJ76 previously approved these changes Feb 24, 2025
View reviewed changes
@RichardHelm RichardHelm enabled auto-merge (squash) February 24, 2025 13:55
YonatanKra
YonatanKra requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor
@YonatanKra YonatanKra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Just a small semantic issue :)

YonatanKra
YonatanKra approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor
@YonatanKra YonatanKra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@RichardHelm RichardHelm merged commit f9328d1 into main Feb 25, 2025
15 checks passed
@RichardHelm RichardHelm deleted the VIV-2352-fix-menu-error branch February 25, 2025 07:12
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YonatanKra YonatanKra YonatanKra approved these changes

@TaylorJ76 TaylorJ76 TaylorJ76 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardHelm @YonatanKra @TaylorJ76
0