From 28d8fe492ebf08353f11a7c2a779f0939b0dd929 Mon Sep 17 00:00:00 2001
From: xile611 <dingling112@gmail.com>
Date: Mon, 29 Apr 2024 16:40:38 +0800
Subject: [PATCH 1/2] fix: fix error of position when update viewBox

---
 packages/vchart/src/chart/interface/chart.ts    | 1 +
 packages/vchart/src/component/crosshair/base.ts | 2 +-
 packages/vchart/src/component/marker/utils.ts   | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/packages/vchart/src/chart/interface/chart.ts b/packages/vchart/src/chart/interface/chart.ts
index 2ed08bc1b2..07e80ab05f 100644
--- a/packages/vchart/src/chart/interface/chart.ts
+++ b/packages/vchart/src/chart/interface/chart.ts
@@ -62,6 +62,7 @@ export interface IChart extends ICompilable {
 
   setCanvasRect: (width: number, height: number) => void;
   getCanvasRect: () => ILayoutRect;
+  getViewRect: () => ILayoutRect;
 
   getOption: () => IChartOption;
 
diff --git a/packages/vchart/src/component/crosshair/base.ts b/packages/vchart/src/component/crosshair/base.ts
index 224a615b6f..b8d36cdc01 100644
--- a/packages/vchart/src/component/crosshair/base.ts
+++ b/packages/vchart/src/component/crosshair/base.ts
@@ -101,7 +101,7 @@ export abstract class BaseCrossHair<T extends ICartesianCrosshairSpec | IPolarCr
 
   protected _getLimitBounds() {
     if (!this._limitBounds) {
-      const { width, height } = this._option.globalInstance.getChart()?.getCanvasRect() ?? {
+      const { width, height } = this._option.globalInstance.getChart()?.getViewRect() ?? {
         width: 0,
         height: 0
       };
diff --git a/packages/vchart/src/component/marker/utils.ts b/packages/vchart/src/component/marker/utils.ts
index 414936696e..92e39cb374 100644
--- a/packages/vchart/src/component/marker/utils.ts
+++ b/packages/vchart/src/component/marker/utils.ts
@@ -244,7 +244,7 @@ export function positionLayout(positions: MarkerPositionPoint[], series: ISeries
     });
   }
 
-  const { width: canvasWidth, height: canvasHeight } = series.getOption().getChart().getCanvasRect();
+  const { width: canvasWidth, height: canvasHeight } = series.getOption().getChart().getViewRect();
   return positions.map(position => {
     let { x, y } = position;
     if (isPercent(x)) {

From e31f66b47e7c77acb4844abaa6b9c49a9c4352d3 Mon Sep 17 00:00:00 2001
From: xile611 <dingling112@gmail.com>
Date: Mon, 29 Apr 2024 16:40:56 +0800
Subject: [PATCH 2/2] docs: update changlog of rush

---
 .../@visactor/vchart/develop_2024-04-29-08-40.json    | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 common/changes/@visactor/vchart/develop_2024-04-29-08-40.json

diff --git a/common/changes/@visactor/vchart/develop_2024-04-29-08-40.json b/common/changes/@visactor/vchart/develop_2024-04-29-08-40.json
new file mode 100644
index 0000000000..9be1a63e07
--- /dev/null
+++ b/common/changes/@visactor/vchart/develop_2024-04-29-08-40.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "fix: fix error of position when update viewBox\n\n",
+      "type": "none",
+      "packageName": "@visactor/vchart"
+    }
+  ],
+  "packageName": "@visactor/vchart",
+  "email": "dingling112@gmail.com"
+}
\ No newline at end of file