[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action commands support #1624

Closed
pciavald opened this issue Mar 28, 2021 · 3 comments · Fixed by #2586
Closed

action commands support #1624

pciavald opened this issue Mar 28, 2021 · 3 comments · Fixed by #2586
Labels
enhancement New feature or request

Comments

@pciavald
Copy link
Contributor
pciavald commented Mar 28, 2021

Is your feature request related to a problem? Please describe.

There's a gcode feature called action commands. It's used to prompt the user when something happens with the printer, for instance a filament runout is detected, or a filament change is going on and the printer wants to know if the color is correct, or a simple message like "bed leveling done".

Describe the solution you'd like

Similar to how octoprint implemented it (and i guess their plugin can be useful), we should implement a machine prompt modal.

Link other projects

https://reprap.org/wiki/G-code#M876:_Dialog_handling

https://docs.octoprint.org/en/master/features/action_commands.html

https://docs.octoprint.org/en/master/bundledplugins/action_command_prompt.html

<<< //action:prompt_begin Filament runout detected. Please choose how to proceed:
<<< //action:prompt_choice Swap filament
<<< //action:prompt_choice Home X/Y and pause print
<<< //action:prompt_choice Abort print
<<< //action:prompt_show
> M876 S1

https://docs.octoprint.org/en/master/bundledplugins/action_command_notification.html

Recv: //action:prompt_end
Recv: //action:notification Bed leveling done.

Additional context

image

image

@pciavald pciavald added the enhancement New feature or request label Mar 28, 2021
@pciavald
Copy link
Contributor Author
pciavald commented Apr 8, 2021

I'm on it but i'm having an issue copying the notification logic to make prompts, strangely in the copy/pasted service i get some observable leak, would you mind having a look ?

@UnchartedBull
Copy link
Owner

sure we're talking about #1661 right? Need to fix the pipeline first though :D. Probably will have some time tomorrow to have a look at this :)

@pciavald
Copy link
Contributor Author
pciavald commented Apr 9, 2021

amazing! i'm stuck on it. Cleaning the i18n PR meanwhile, to stop the conflict resolution battle lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants