[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedrate decrease does not issue M220 #1618

Closed
mpalm0508 opened this issue Mar 27, 2021 · 2 comments · Fixed by #1676
Closed

Feedrate decrease does not issue M220 #1618

mpalm0508 opened this issue Mar 27, 2021 · 2 comments · Fixed by #1676
Assignees
@UnchartedBull
Labels
bug Something isn't working

Comments

@mpalm0508
Copy link

Describe the bug
When decreasing feed rate a M220 is not sent with the new value. Increase is fine. My current build is from the lastest commit as of 3/27/2021

Decrease to 100
Send: N6356 G1 X58.007 Y132.228 E3.11742100
Recv: ok
Send: N6357 M104 S20585
Recv: ok
Send: N6358 M140 S55109
Recv: ok
Send: N6359 M106 S19187
Recv: ok
Send: N6360 G1 X58.219 Y131.862 E0.01431*110
Recv: ok

Increase works as expected.

Send: N6305 G1 X110.921 Y197.250 E1.76234*85
Recv: ok
Send: N6306 M104 S205*81
Recv: ok
Send: N6307 M140 S55*103
Recv: ok
Send: N6308 M106 S191*83
Recv: ok
Send: N6309 M220 S150*88
Recv: ok
Send: N6310 G1 X111.497 Y197.250 E0.01955*93
@mpalm0508 mpalm0508 added the bug Something isn't working label Mar 27, 2021
@mpalm0508
Copy link
Author

Looking though the source it looks like this issue is only a problem trying to set feedrate back to 100. Looking at printer.octoprint.services.ts (starting line 105) if feedrate is 100 it just drops out. Quick fix it to remove the check but not sure the reasoning behind it.

public setFeedrate(feedrate: number): void { if (feedrate === 100) { return; }

@UnchartedBull
Copy link
Owner

I honestly can't tell you why it just returns on 100. I'll check this and make sure to fix this before the next release.

@UnchartedBull UnchartedBull mentioned this issue Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UnchartedBull UnchartedBull

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix settings, feedrate, add axis inversion UnchartedBull/OctoDash
2 participants
@UnchartedBull @mpalm0508