[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: wrong validation if "additionalProperties" has boolean value false #2296

Open
danipindado opened this issue Aug 7, 2024 · 1 comment
Open

Bug: wrong validation if "additionalProperties" has boolean value false #2296

danipindado opened this issue Aug 7, 2024 · 1 comment

Comments

@danipindado
Copy link
danipindado commented Aug 7, 2024 •
edited
Loading

there is a bug in how additionalProperties is handled.
additionalProperties = false, ensures that no properties other than those defined in properties or patternProperties are allowed, see draft-4 spec.

Therefore, if additionalProperties s false, All required properties must be defined in either properties or patternProperties.

this is not the case.

see this example:

{
  "$schema": "https://json-schema.org/draft-04/schema",
  "title": "Example Schema",
  "description": "A generic schema with four properties",
  "type": "object",
  "properties": {
    "propertyOneTypo": {
      "type": "string",
      "description": "A string property"
    },
    "propertyTwo": {
      "type": "number",
      "description": "A number property"
    },
    "propertyThree": {
      "type": "boolean",
      "description": "A boolean property"
    },
    "propertyFour": {
      "type": "array",
      "items": {
        "type": "string"
      },
      "description": "An array of strings"
    }
  },
  "required": ["propertyOne", "propertyTwo", "propertyThree", "propertyFour"],
  "additionalProperties": false
}

{
  "propertyOne": "example string",
  "propertyTwo": 42,
  "propertyThree": true,
  "propertyFour": ["item1", "item2", "item3"]
}

the json input file has a property called "propertyOne". this property is neither defined in properties or patternProperties. the verification should fail. but it does not.

valijson 0.6 triggers an error when using the web based live demo

Error validating JSON schema:
Error #0
  context: <root>
  message: Object contains a property that could not be validated using 'properties' or 'additionalProperties' constraints: 'propertyOne'.

validation fails in vscode json schema validator too.
and also in the the validator here:
https://www.jsonschemavalidator.net/s/rHhkxQRh

rapidjson considers the file as valid.
@danipindado danipindado changed the title rapidjson allows non-existing properties in 'required'. and does not trigger an error for them, even if 'additionalProperties' ist set to false Wrong validation if "additionalProperties" has boolean value false and "required" is used Sep 27, 2024
@danipindado danipindado changed the title Wrong validation if "additionalProperties" has boolean value false and "required" is used Bug: wrong validation if "additionalProperties" has boolean value false Sep 30, 2024
@danipindado
Copy link
Author

i have checked out current head and i can reproduce the problem with unittest by inserting this test case in required.json,

    {
        "description": "bug: required properties mess up with additionalProperties handling",
        "schema": {
            "properties": {
                "A": {},
                "B": {}
            },
            "required": ["B","C"],
            "additionalProperties": false
        },
        "tests": [
            {
                "description": "invalid due to missing C",
                "data": {"A": 1,"B": 1},
                "valid": false
            },
            {
                "description": "invalid due to presence of C and additionalProperties == false",
                "data": {"B": 1,"C": 1},
                "valid": false
            }
        ]
    }

Fail: jsonschema/tests/draft4/required.json "bug: required properties mess up with additionalProperties handling" "invalid due to presence of C and additionalProperties == false"

i think the problem has to do with how properties_ array is built during schema parsing here.
required properties are added to the same array, and, later, they are flagged as required.

the function FindePropertyIndex which is used to see if additional properties have been added, checks the entire properties_ array. it does not check if originally the property was part of "properties" or "required". and this is the problem. because according spec, only "properties" and "patternProperties" are relevant for "additionalProperties" handling.

one would need maybe an additional member in the Property class to see if the property was originally in "properties" object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danipindado