8000 gcc warning when compiling with plog · Issue #79 · SergiusTheBest/plog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

gcc warning when compiling with plog #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eldadr opened this issue Jan 14, 2018 · 2 comments
Closed

gcc warning when compiling with plog #79

eldadr opened this issue Jan 14, 2018 · 2 comments
Assignees
@SergiusTheBest
Milestone
1.1.4

Comments

@eldadr
Copy link
eldadr commented Jan 14, 2018

When compiling our C++ software with plog, we have the following gcc warning (multiple times):

../plog/include/plog/Record.h:99:11: warning: ‘class plog::Record’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
     class Record
           ^

gcc version: gcc 5.4.0-6ubuntu1
gcc flags: -std=c++03 -pg -O0 -g -Wall -Wextra -pthread
plog version: 1.1.3
SergiusTheBest added a commit that referenced this issue Jan 14, 2018
@SergiusTheBest
Fix -Wnon-virtual-dtor warning (#79).
a55a641
@SergiusTheBest
Copy link
Owner

It's strange bacause -Wall doesn't include -Wnon-virtual-dtor. Anyway I pushed the fix.

@SergiusTheBest SergiusTheBest self-assigned this Jan 14, 2018
@SergiusTheBest SergiusTheBest added this to the 1.1.4 milestone Jan 14, 2018
@eldadr
Copy link
Author
eldadr commented Jan 15, 2018

Thanks.
Apparently the -Wnon-virtual-dtor flag was added to the gcc command under the hood by the build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergiusTheBest SergiusTheBest

Labels
None yet
Projects
None yet
Milestone
1.1.4
Development

No branches or pull requests
2 participants
@SergiusTheBest @eldadr
0