Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 4 commits
- 2 files changed
- 3 contributors
Commits on Dec 5, 2016
Commits on Jan 4, 2018
-
jwt_test: Fix test assertions to use || instead of &&
Two of the test cases in jwt_test.go perform several checks against the claimset but require that all of them be true (&&) in order to trigger the assert. More than likely, this is not the desired behavior and the error should actually be triggered if any (||) of the conditions is true. This change modifies TestJWTValidator and TestBasicJWT to use || instead of && to chain the conditionals in their assertion.
-
jwt_test: Fix the way scopes were being checked in the test
After fixing the tests to properly check all the conditionals, the TestBasicJWT test began to fail because calling .Get('scopes') to retrieve the scopes claim returns an interface{} which cannot be converted into the []string value via a type assertion because it's actually an []interface{} under the hood. The way to fix that is to change the type assertion to assert to []interface{} and then compare against the [0] value in that slice. -
Merge pull request #35 from mark-adams/fix-tests
Minor fixes to jwt_test.go
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.1...master