8000 JSStream class>>encodeString:on: optimizes speed for Pharo but not always for other platforms. Move to platform-specific package. · Issue #1458 · SeasideSt/Seaside · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JSStream class>>encodeString:on: optimizes speed for Pharo but not always for other platforms. Move to platform-specific package. #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbrichau opened this issue May 19, 2025 · 0 comments
Open

JSStream class>>encodeString:on: optimizes speed for Pharo but not always for other platforms. Move to platform-specific package. #1458

jbrichau opened this issue May 19, 2025 · 0 comments

Comments

@jbrichau
Copy link
Member

The implementation of JSStream class>>encodeString:on: is a hotspot method when generating large pieces of Javascript. As such, its optimization is important. Optimizations may differ between platforms, requiring a specialization per supported platform.

In VAST, because of the distinction between String with Character and UnicodeString with Grapheme, the optimization needs to be very different to obtain reasonable speeds.

Therefore, the implementation of this method should be moved to platform-specific packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbrichau
0