Open
Description
Bug Report
Current Behavior
When run locally, the test "Manifest validates against the schema" only runs on package manifests.
But when $env:CI -eq $true
, the test runs on ALL JSON files, including non-manifest JSON files e.g. ".vscode/settings.json".
Expected Behavior
The test should only run on package manifest files.
Additional context/output
https://github.com/BinToss/scoop-bucket/actions/runs/15766175227/job/44442972909
Possible Solution
In "test/Import-Bucket-Tests.ps1", prepend the Get-GitChangedFile
Include
pattern with the name of $bucketDir
.
- $manifestFiles = @(Get-GitChangedFile -Path $bucketDir -Include '*.json' -Commit $env:BHCommitHash)
+ $manifestFiles = @(Get-GitChangedFile -Path $bucketDir -Include "$((Get-Item $bucketDir).Name)/*.json" -Commit $env:BHCommitHash)
This ensures Get-GitChangedFile
only returns the paths of JSON files under the bucket directory and nowhere else.
System details
Windows version: 11
OS architecture: 64bit
PowerShell version: 7.5.1
Scoop Configuration
{
"last_update": "2025-06-19T11:15:43.8285017-07:00",
"alias": {
"upgrade": "scoop-upgrade",
"outdated": "scoop-outdated"
},
"scoop_branch": "develop",
"scoop_repo": "https://github.com/ScoopInstaller/Scoop",
"aria2-enabled": true,
"use_sqlite_cache": true
}