8000 Refactor thunks out of Store · Issue #14 · Roblox/rodux · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor thunks out of Store #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AmaranthineCodices opened this issue Mar 5, 2018 · 2 comments · Fixed by #17
Closed

Refactor thunks out of Store #14

AmaranthineCodices opened this issue Mar 5, 2018 · 2 comments · Fixed by #17
Labels
enhancement
Milestone
1.0

Comments

@AmaranthineCodices
Copy link
Contributor

This depends on #5 (and #13 or an equivalent). We should refactor thunks out of the core dispatch method and move them to a middleware (how redux-thunk works). This middleware should probably be bundled by default, since thunks were implemented in Rodux before.
@LPGhatguy
Copy link
Contributor

Should that middleware be enabled by default?

I'm not 100% confident that thunks are the best way to go about asynchronous tasks, so letting them be optional seems like a good idea.

@AmaranthineCodices
Copy link
Contributor Author

I'd include them in Rodux, but not enable them by default. If people want thunks, they can enable the middleware themselves, but I don't see a need to enable them as-is.

@AmaranthineCodices AmaranthineCodices mentioned this issue Mar 8, 2018
Merged
4 tasks
@LPGhatguy LPGhatguy added this to the 1.0 milestone Mar 8, 2018
@AmaranthineCodices AmaranthineCodices mentioned this issue Mar 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Move thunks out of Store AmaranthineCodices/rodux
2 participants
@LPGhatguy @AmaranthineCodices
0