8000 Allow resizing of the side-nav (in Firefox) · Issue #20414 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow resizing of the side-nav (in Firefox) #20414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Remmirad opened this issue Feb 22, 2024 · 2 comments · Fixed by #20511
Closed

Allow resizing of the side-nav (in Firefox) #20414

Remmirad opened this issue Feb 22, 2024 · 2 comments · Fixed by #20511

Comments

@Remmirad
Copy link

Description

At the moment it is not possible to resize the side-nav/tree-nav of the RIOT-doxygen website in Firefox (might apply to other browsers). When the tree is expanded this makes reading it a bit cumbersome.

This is caused by

RIOT/doc/doxygen/src/js/riot-doxy.js

Line 47 in 543c62f

function resize_handler()
being called even when resizing the side-nav not only the window. Line 64 then always resets the width. Adding if ($(window).width() == window_before) {return;} to the beginning of resize_handler fixes that.

Is the side-nav not being resizable a deliberate decision or a bug (in which case I would like to fix it)?

Steps to reproduce the issue

Open https://doc.riot-os.org/ and try to resize the side-nav on the left (using firefox)

Expected results

Side-nav resizes accordingly

Actual results

Side-nav remains in the same width
@maribu
Copy link
Member
maribu commented Mar 27, 2024

I think this is a bug. I can confirm that the proposed fix solves the issue.

Would you mind to open a PR for that?

@Remmirad
Copy link
Author

Thanks for checking this. I'll open a PR.

@Remmirad Remmirad mentioned this issue Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: Allow resizing of doxygen side-nav Remmirad/RIOT
2 participants
@maribu @Remmirad
0