8000 Fix hue modulo operation by adroitwhiz · Pull Request #50 · Qix-/color-string · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix hue modulo operation #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix hue modulo operation #50

wants to merge 1 commit into from

Conversation

adroitwhiz
Copy link
Contributor

This modulo operation was removed in #37 under the mistaken impression that it was unnecessary. However, it's required for a proper "wrapping modulo"--without it, hue values lower than -360 will not be made positive.

I've added a test that checks for such a case specifically.

@Qix-
Copy link
Owner
Qix- commented Nov 26, 2021

Thanks, and sorry for the delay on this. Landed ultimately in 9563250 and published as 1.7.3.
6E45

@Qix- Qix- closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adroitwhiz @Qix-
0