From 03eaa8a81bd1d9bf2272f9439d74f305df9b8825 Mon Sep 17 00:00:00 2001 From: IKEDA Sho Date: Thu, 21 May 2020 23:54:03 +0900 Subject: [PATCH] [SwiftLint] Enable type_name rule --- .swiftlint.yml | 1 - Sources/Quick/Callsite.swift | 2 ++ Sources/Quick/Example.swift | 2 ++ Sources/Quick/ExampleMetadata.swift | 2 ++ Sources/Quick/Filter.swift | 2 ++ Sources/Quick/World.swift | 2 ++ Tests/.swiftlint.yml | 2 ++ 7 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 Tests/.swiftlint.yml diff --git a/.swiftlint.yml b/.swiftlint.yml index 79cda08fb..92aabd766 100644 --- a/.swiftlint.yml +++ b/.swiftlint.yml @@ -1,6 +1,5 @@ disabled_rules: - line_length - - type_name - function_body_length - identifier_name included: diff --git a/Sources/Quick/Callsite.swift b/Sources/Quick/Callsite.swift index 9250a1772..33e732ca5 100644 --- a/Sources/Quick/Callsite.swift +++ b/Sources/Quick/Callsite.swift @@ -1,10 +1,12 @@ import Foundation #if canImport(Darwin) +// swiftlint:disable type_name @objcMembers public class _CallsiteBase: NSObject {} #else public class _CallsiteBase: NSObject {} +// swiftlint:enable type_name #endif // Ideally we would always use `StaticString` as the type for tracking the file name diff --git a/Sources/Quick/Example.swift b/Sources/Quick/Example.swift index 036aa3ad1..b351a228b 100644 --- a/Sources/Quick/Example.swift +++ b/Sources/Quick/Example.swift @@ -1,10 +1,12 @@ import Foundation #if canImport(Darwin) +// swiftlint:disable type_name @objcMembers public class _ExampleBase: NSObject {} #else public class _ExampleBase: NSObject {} +// swiftlint:enable type_name #endif /** diff --git a/Sources/Quick/ExampleMetadata.swift b/Sources/Quick/ExampleMetadata.swift index 2cdd10faa..a8f0d7765 100644 --- a/Sources/Quick/ExampleMetadata.swift +++ b/Sources/Quick/ExampleMetadata.swift @@ -1,10 +1,12 @@ import Foundation #if canImport(Darwin) +// swiftlint:disable type_name @objcMembers public class _ExampleMetadataBase: NSObject {} #else public class _ExampleMetadataBase: NSObject {} +// swiftlint:enable type_name #endif /** diff --git a/Sources/Quick/Filter.swift b/Sources/Quick/Filter.swift index 3382d38f8..d7fbe8d79 100644 --- a/Sources/Quick/Filter.swift +++ b/Sources/Quick/Filter.swift @@ -1,10 +1,12 @@ import Foundation #if canImport(Darwin) +// swiftlint:disable type_name @objcMembers public class _FilterBase: NSObject {} #else public class _FilterBase: NSObject {} +// swiftlint:enable type_name #endif /** diff --git a/Sources/Quick/World.swift b/Sources/Quick/World.swift index 57246e657..05109e7e7 100644 --- a/Sources/Quick/World.swift +++ b/Sources/Quick/World.swift @@ -13,10 +13,12 @@ public typealias SharedExampleContext = () -> [String: Any] public typealias SharedExampleClosure = (@escaping SharedExampleContext) -> Void #if canImport(Darwin) +// swiftlint:disable type_name @objcMembers internal class _WorldBase: NSObject {} #else internal class _WorldBase: NSObject {} +// swiftlint:enable type_name #endif /** diff --git a/Tests/.swiftlint.yml b/Tests/.swiftlint.yml new file mode 100644 index 000000000..cc973d9e2 --- /dev/null +++ b/Tests/.swiftlint.yml @@ -0,0 +1,2 @@ +disabled_rules: + - type_name