Make t/53lean_startup.t robust wrt stacktrace details #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test checks if none of DBIC is loading anything unexpected. It contains logic to skip over indirect loaders such as base, parent and Class::C3::Componentised. However, this erroneously skips over direct dependencies of such classes. In particular, it assigns the MRO::Compat dependency in Class::C3::Componentised to whatever class it thinks it loads CCC. Before ad89278 this worked out fine, because it would be assigned to main, which while meaningless isn't part of DBIx::Class so ignored. After ad89278, it's assigned to the class that loads CCC, which is DBIx::Class::Componentised, which is part of DBIC, and hence fails the test. This test will cause it to not skip on for any BEGIN blocks inside an indirect loader, therefor the MRO::Compat dependency will correctly be assigned to Class::C3::Componentised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or
2BEA
marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks if none of DBIC is loading anything unexpected. It
contains logic to skip over indirect loaders such as base, parent and
Class::C3::Componentised. However, this erroneously skips over direct
dependencies of such classes. In particular, it assigns the MRO::Compat
dependency in Class::C3::Componentised to whatever class it thinks it
loads CCC. Before ad89278 this worked out fine, because it would be
assigned to main, which while meaningless isn't part of DBIx::Class so
ignored. After ad89278, it's assigned to the class that loads CCC, which
is DBIx::Class::Componentised, which is part of DBIC, and hence fails
the test.
This test will cause it to not skip on for any BEGIN blocks inside an
indirect loader, therefor the MRO::Compat dependency will correctly be
assigned to Class::C3::Componentised.