During leagues match reports we do not update standings unless there are no open matches #913
Comments
|
Discussing this with Iron_lungs he does get people asking why the standings haven't updated with their matches. So I guess for leagues specifically we should update with each confirmed result even if there are partial results open. But probably not outside of leagues where that would give misleading hints about tiebreakers and generally be confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If there is an unconfirmed match report the reporting a match (even if verified) will not update the standings.
Matchup::unresolvedMatchesCheck($subevent, $round)must return 0 otherwise the result of the reported/confirmed/verified match will be left as 'P' (pending). When all matches are closed out this does somehow update all the 'P' matches to the right state.Further notes:
We add the match after it being reported, and "verify" it, but we don't update the result from 'P'
Then we call some other part of the code that updates the 'P' to either 'A' or 'B' depending on who won
But that part of the code says:
$matches_remaining = Matchup::unresolvedMatchesCheck($subevent, $round);
so essentially standings will never be recalculated correctly as long as there is a partially "open" match
This code of course all written before leagues were a thing and the person writing it had tournaments in mind where you don't update the standings and do the next pairings until all the results are in
So for leagues we should just trust the match report of whoever reports first and recalulcate standings every time? Or does a mod have to confirm? Do we need to change the behavior?
The text was updated successfully, but these errors were encountered: