8000 POT file for localization needs to be updated with all strings · Issue #109 · PTC-ALM/TortoiseSI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

POT file for localization needs to be updated with all strings #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KristinaTaylor opened this issue Mar 26, 2015 · 6 comments
Open

POT file for localization needs to be updated with all strings #109

KristinaTaylor opened this issue Mar 26, 2015 · 6 comments
Assignees
@atusek
Milestone
1.1

Comments

@KristinaTaylor
Copy link

Update the PO template files with all strings that have been added up to this point.

Make sure that appropriate developer information is in the wiki for how to generate/update language files.
@KristinaTaylor KristinaTaylor added this to the Alpha Release milestone Mar 26, 2015
@bleskowskyPTC bleskowskyPTC self-assigned this Apr 1, 2015
@bleskowskyPTC
Copy link

Will generate the template once alpha code tasks are completed. In the meantime, I will see what information is currently available under source-control for generating/updating po related files, and port relevant information to the wiki

@KristinaTaylor
Copy link
Author

PO template generation is proving to be a challenge. There are a lot of strings (565) in the existing resource headers that aren't actually in use for TortoiseSI, but came over from TortoiseGit.

Offering new translations for existing languages may 8000 actually be more easily done as a manual contribution process, rather than being committed directly to the repository by translators.

@KristinaTaylor KristinaTaylor modified the milestones: Alpha, Beta Apr 10, 2015
@bleskowskyPTC
Copy link

Work that has been done:
Most information in /Languages/translations.txt has been ported to the wiki under Localization page. Future revisions will be needed for this page regarding the contribution process for translators. In short, since we advise translators to use a tool like poEdit to generate translations and translators are very likely not going to be well versed in using Git revision control, as per @KristinaTaylor 's comments above, a manual contribution process is advised.

Investigation notes:

  • To complete this task, need to clean a LOT of unused strings from resource.h. These are basically remnants of other resources used by TortoiseGit, etc. which are no longer needed/referenced since we have dropped almost all the TortoiseGit dialogs. The easiest way to remove strings is to look in the Visual Studio 2013 solution Resource View, right click on the .rc file of interest, and select Resource Symbols... This provides a view of resource symbols and indicates whether they are in use or not, and who is using them. Unused keys can be deleted (one by one unfortunately, unless you can find a better way) from here. Deleting keys directly from the header file may potentially cause your code to stop compiling if you accidentally delete a key that was being used somewhere.
  • After generating the pot file based on changes I made from simply deleting unused resources, there were still a large number of strings that could not be traced from the .rc files (template contained 500+ strings for translation). Ex: ResourceID: 3867, "%1 contains an incorrect path." Unable to grep this string anywhere in the solution. Investigation for where resources like these come from will be needed.
  • Additional files to be updated / changes: add TortoiseProcLang project to solution (project already exists, just need to add to solution; see TortoiseShellLang for reference), /Languages/Make_Pot.bat, /Languages/TortoisePotHeader.txt, /Languages/Makefile (add TortoiseProcLang.dll).

@krrish1008 krrish1008 mentioned this issue Jul 23, 2015
Merged
@krrish1008
Copy link

Update:
Unused strings from the resource.h from both TortoiseShell and TortoiseProc have been cleaned. the Make_Pot.bat has been updated (added the TortoiseShell.dll). The Tortoise.pot file have been updated with the TortoiseShell strings.
Now working on the TortoisProcLang. Added the DLL file in the batch file and have generated the POT file but some of the untracked string were generated which cannot be found. Still trying to trace those strings and remove them.
But the tortoise.pot file is ready to be translated as, the repo doesn't have the TortoiseProc DLL added.

This was referenced Sep 1, 2015
Closed
Merged
@atusek atusek assigned atusek and unassigned krrish1008 Sep 22, 2015
@atusek
Copy link
atusek commented Sep 22, 2015

The additional strings appearing in the POT file are originating from the TortoiseSIProc project. The source of these additional resources are as follows:

• Unused dialogs from the TortoiseSIProc project inherited from TortoiseGit
• Include files in TortoiseProc.rc2 that include additional strings not currently in use (TortoiseLoglistCommon.rc2)
• Dependence on MFC framework whose resources are included in the TortoiseProceLang.dll

Additional MFC strings amount to ~320. A quick check of the .po files that are being generated for TortoiseGit (https://www.transifex.com/lznuaa/tortoisegit/tortoisepot/) appear to contain translations fr the MFC resource strings. These could be reused. Microsoft also provides localized MFC resources.

Decision is to include only TortoiseSIShell resources in the .POT file and add the TortoiseSIProc specific resources later when the functionality comes online.

No current updates required to Make_Pot.bat file since it currently only references TortoiseShellLang.dll. The TortoiseProcLang.dll will be added at a later time at which time the unused dialogs and unneeded files will also be removed (see above). This will be taken on as a Post 1.0 activity. Additional work/configuration will also need to be done to generate the locale specific TortoiseProc resource .dlls.

This was referenced Sep 22, 2015
Open
Open
Open
@KristinaTaylor KristinaTaylor modified the milestones: Post 1.0, Beta Sep 23, 2015
@KristinaTaylor
Copy link
Author

Remaining work has been moved to the post 1.0 milestone.

@KristinaTaylor KristinaTaylor modified the milestones: 1.1, Post 1.0 Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atusek atusek

Labels
None yet
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
4 participants
@atusek @krrish1008 @KristinaTaylor @bleskowskyPTC
0