8000 Using only .py files from git index - [closed] · Issue #858 · PyCQA/flake8 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Using only .py files from git index - [closed] #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asottile opened this issue Apr 3, 2021 · 5 comments
Closed

Using only .py files from git index - [closed] #858

asottile opened this issue Apr 3, 2021 · 5 comments
Labels
gitlab merge request

Comments

@asottile
8000 Copy link
Member
asottile commented Apr 3, 2021

In GitLab by @jeverling on May 30, 2017, 07:24

Merges defect/325-use-only-py-files-from-git -> master

Fixes #325
@asottile
Copy link
Member Author
asottile commented Apr 3, 2021

In GitLab by @codecov on May 30, 2017, 07:25

Codecov Report

Merging #189 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   68.84%   68.82%   -0.02%     
==========================================
  Files          27       27              
  Lines        2221     2223       +2     
  Branches      361      362       +1     
==========================================
+ Hits         1529     1530       +1     
  Misses        617      617              
- Partials       75       76       +1
Impacted Files Coverage Δ
src/flake8/main/git.py 34.21% <66.66%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c6577...e011adf. Read the comment docs.

@asottile
Copy link
Member Author
asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on May 30, 2017, 15:23

Commented on src/flake8/main/git.py line 165

We had something akin to this but it was causing issues previously. People do write Python in files that don't end in .py and do want those files checked.

@asottile
Copy link
Member Author
asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on May 30, 2017, 15:24

Thank you for your effort @jeverling! Unfortunat 8000 ely, the approach you've taken is not suitable. Please let me know if you're up for further debugging/hacking or if I should attempt to tackle this myself.

@asottile
Copy link
Member Author
asottile commented Apr 3, 2021

In GitLab by @jeverling on May 31, 2017, 04:30

I am up, but quite busy atm so it might take a while until I actually get around to work on it.

@asottile
Copy link
Member Author
asottile commented Apr 3, 2021

In GitLab by @jeverling on May 31, 2017, 04:30

closed

@asottile asottile closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gitlab merge request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asottile
0