8000 Use fully qualified identifiers in macro generated code · Issue #74 · Kolos65/Mockable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use fully qualified identifiers in macro generated code #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wvteijlingen-npo opened this issue Sep 5, 2024 · 0 comments · Fixed by #81
Closed

Use fully qualified identifiers in macro generated code #74

wvteijlingen-npo opened this issue Sep 5, 2024 · 0 comments · Fixed by #81

Comments

@wvteijlingen-npo
Copy link
wvteijlingen-npo commented Sep 5, 2024 •
edited
Loading

In our codebase we have a protocol called Matchable. This clashes with the Matchable protocol defined in the Mockable package. I think a safe precaution would be to use a fully qualified identifier in the code generated by the macro.

enum Member: Mockable.Matchable, Mockable.CaseIdentifiable {
    // ...
}

Unfortunately this will require some renaming, since Mockable will resolve to the Mockable protocol instead of the package.

Perhaps this can be extended to other protocols such as CaseIdentifiable, EffectBuilder and AssertionBuilder as well.
@wvteijlingen-npo wvteijlingen-npo changed the title Mockable.Matchable protocol clashes with our own protocol from code base Matchable protocol clashes with protocol from our own code base Sep 5, 2024
@wvteijlingen-npo wvteijlingen-npo changed the title Matchable protocol clashes with protocol from our own code base Use fully qualified identifiers in macro generated code Sep 6, 2024
@Kolos65 Kolos65 linked a pull request Sep 27, 2024 that will close this issue
Fix name collisions #81
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix name collisions Kolos65/Mockable
1 participant
@wvteijlingen-npo
0