8000 Aqua Scepter is listed as a drop from Duke Fishron · Issue #160 · JavidPack/RecipeBrowser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ RecipeBrowser Public

Aqua Scepter is listed as a drop from Duke Fishron #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Flurryous opened this issue Dec 23, 2024 · 2 comments
Open

Aqua Scepter is listed as a drop from Duke Fishron #160

Flurryous opened this issue Dec 23, 2024 · 2 comments

Comments

@Flurryous
Copy link

As title. Aqua Scepter is a pre-hardmode weapon that's usually obtained from the dungeon chests or golden lock boxes. For some reason though, the recipe browser lists the Aqua Scepter as a drop from Duke Fishron.

I had several mods on when I first noticed this, but I have searched this weapon in the recipe browser after disabling the rest of the mods, and the issue is still there, so it's likely a recipe browser bug.
@Flurryous
Copy link
Author
Flurryous commented Jan 4, 2025 •
edited
Loading

Found out that certain world seeds swap the Aqua Scepter with the Bubble Gun, so that's probably why the scepter is listed as a Duke Fishron drop in the recipe browser.

edit: Though my world seed isn't one of those that have the weapons swapped. I'll just leave this ticket open for now.

@Flurryous Flurryous reopened this Jan 4, 2025
@JavidPack
Copy link
Owner

Thanks for the report. I looked into this and finding a solution for this will be a bit difficult due to how the code is organized.

As far as RecipeBrowser is concerned, Aqua Scepter is a drop of Duke Fishron because it has a drop rule that has that item as a drop. The issue is the drop rule has a condition that isn't being checked. Some drop rule conditions are for world seeds, which wouldn't change in-game, and others are for things that can change such as how deep or hardmode. Determining which drops to hide completely and which to show despite conditions not being satisfied will be a bit tricky.

In the meantime, maybe I'll find some way of mentioning drop rule conditions somewhere in the UI (#137). A lot of drops are hardmode only as well, so that should help users know not to farm for an item that can't drop in prehardmode as well. I'm not sure how I'll end up fixing this issue at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JavidPack @Flurryous
0