Add warning to InMemory Service Registry #750
Conversation
| * Instantiates a new In memory service registry. | ||
| */ | ||
| public InMemoryServiceRegistryDaoImpl() { | ||
| LOGGER.warn("[{}] is designed to retrieve and persist service definitions in memory. Changes that are made to service definitions during runtime " |
There was a problem hiding this comment.
Class name seems redundant since most loggers already output the class name.
There was a problem hiding this comment.
This is also fixed of course.
|
Pull is updated to address feedback. |
| /** | ||
| * This is test cases for {@link org.jasig.cas.services.InMemoryServiceRegistryDaoImpl}. | ||
| * | ||
| * @author Misagh Moayyed mmoayyed@unicon.net |
|
Why not? +1 |
| public class InMemoryServiceRegistryDaoImplTests { | ||
|
|
||
| @Test | ||
| public void testSave() { |
There was a problem hiding this comment.
I find the usage of "test" to be redundantly annoying but not enough to care. We may want to declare one way or the other in our standards if we haven't. (we probably have a mix now)
There was a problem hiding this comment.
That's a fine idea. I have got some CS and FindBugs items planned ahead. I'll account for this as well in the standards. Would be a lot of noise to get this fixed as you noted, we have a mix right now but consistency one way or another would be even better.
|
+1 |
Add warning to InMemory Service Registry
Partially addresses: https://github.com/Jasig/cas/issues/548
This pull adds a warning to the InMemory Service Registry to note/stress the InMemory nature of the persistence backend. This is to allow CAS adopters to better understand that changed made at runtime will be lost upon container restarts.
Also added some test cases for the class.