JSON serialization of RegisteredService into LDAP #741
Conversation
Conflicts: cas-server-core/src/main/java/org/jasig/cas/util/JsonSerializer.java
| @@ -77,6 +77,10 @@ public void setSalt(final String salt) { | |||
| LOGGER.warn("setSalt() is deprecated and will be removed. Use the constructor instead."); | |||
| } | |||
|
|
|||
| public byte[] getSalt() { | |||
There was a problem hiding this comment.
Not sure to understand how this is related to the current PR?
There was a problem hiding this comment.
A serializable component like the one above requires a getter.
|
Updated. |
|
+1 |
|
Further updated based on Daniel's suggestion on the attribute retrieval. |
| String v = null; | ||
| if (attr.isBinary()) { | ||
| final byte[] b = attr.getBinaryValue(); | ||
| v = new String(b, Charset.forName("UTF-8")); |
There was a problem hiding this comment.
It finally occurred to me why this is happening. You're serializing JSON with line feeds. The UnboundID provider sets the attribute as binary because the line feed requires base64 encoding per the LDIF spec. I'll raise an issue to investigate further.
There was a problem hiding this comment.
Great, thanks. My previous JSON snippet does not show it correctly, but there are \n\r elements in the final outcome which per your explanation causes the attribute to be marked as binary.
There was a problem hiding this comment.
Filed this issue:
vt-middleware/ldaptive#14
Conflicts: cas-server-core/src/main/java/org/jasig/cas/services/AbstractRegisteredService.java cas-server-support-ldap/src/main/java/org/jasig/cas/adaptors/ldap/services/DefaultLdapServiceMapper.java cas-server-support-ldap/src/main/java/org/jasig/cas/adaptors/ldap/services/LdapRegisteredServiceMapper.java
Conflicts: cas-server-core/src/test/java/org/jasig/cas/services/JsonServiceRegistryDaoTests.java
JSON serialization of RegisteredService into LDAP
Handles https://github.com/Jasig/cas/issues/681
I striped down the
DefaultLdapMapperso the entire service definition is persisted into a single attribute as JSON. There are setters that allow extending the serializer, and I also modified the tests to adjust the objectclass required. Some classes had to include getters for serialization to properly work.